Patchwork kconfig cleanup (failover config flags)

login
register
about
Submitter Patrick Georgi
Date 2009-10-03 20:11:08
Message ID <1254600668.12717.1.camel@tetris>
Download mbox | patch
Permalink /patch/325/
State Accepted
Commit r4714
Headers show

Comments

Patrick Georgi - 2009-10-03 20:11:08
Hi,

attached patch moves the failover configuration symbols to a global
file, defined as bool, defaulting to false.
Given that Kconfig doesn't support failover, there hardly will be a
reason to enable it, and if there is, they can still be enabled as
needed.


Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Peter Stuge - 2009-10-03 20:55:41
Patrick Georgi wrote:
> attached patch moves the failover configuration symbols to a global
> file, defined as bool, defaulting to false.
> Given that Kconfig doesn't support failover, there hardly will be a
> reason to enable it, and if there is, they can still be enabled as
> needed.
> 
> 
> Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>

Acked-by: Peter Stuge <peter@stuge.se>


> +config HAVE_FAILOVER_BOOT
> +config USE_FAILOVER_IMAGE

Could we simplify to config FAILOVER or even further? Maybe something
to look into when implementing it for CBFS.


//Peter
Patrick Georgi - 2009-10-03 21:05:03
Am Samstag, den 03.10.2009, 22:55 +0200 schrieb Peter Stuge:
> Acked-by: Peter Stuge <peter@stuge.se>
Thanks, r4714

> > +config HAVE_FAILOVER_BOOT
> > +config USE_FAILOVER_IMAGE
> 
> Could we simplify to config FAILOVER or even further? Maybe something
> to look into when implementing it for CBFS.
They are still in use by newconfig, and are both required - They're only
here so the code makes the right decisions. Nothing to simplify at this
point.


Patrick

Patch

Index: src/Kconfig
===================================================================
--- src/Kconfig	(Revision 4713)
+++ src/Kconfig	(Arbeitskopie)
@@ -146,6 +146,14 @@ 
 	bool
 	default y
 
+config HAVE_FAILOVER_BOOT
+	bool
+	default n
+
+config USE_FAILOVER_IMAGE
+	bool
+	default n
+
 config HAVE_HARD_RESET
 	bool
 	default 0
Index: src/mainboard/supermicro/h8dme/Kconfig
===================================================================
--- src/mainboard/supermicro/h8dme/Kconfig	(Revision 4713)
+++ src/mainboard/supermicro/h8dme/Kconfig	(Arbeitskopie)
@@ -76,16 +76,6 @@ 
 	default 0x100000
 	depends on BOARD_SUPERMICRO_H8DME
 
-config HAVE_FAILOVER_BOOT
-	bool
-	default n
-	depends on BOARD_SUPERMICRO_H8DME
-
-config USE_FAILOVER_IMAGE
-	bool
-	default n
-	depends on BOARD_SUPERMICRO_H8DME
-
 config MAX_CPUS
 	int
 	default 4
Index: src/mainboard/amd/serengeti_cheetah/Kconfig
===================================================================
--- src/mainboard/amd/serengeti_cheetah/Kconfig	(Revision 4713)
+++ src/mainboard/amd/serengeti_cheetah/Kconfig	(Arbeitskopie)
@@ -72,16 +72,6 @@ 
 	default y
 	depends on BOARD_AMD_SERENGETI_CHEETAH
 
-config HAVE_FAILOVER_BOOT
-	bool
-	default n
-	depends on BOARD_AMD_SERENGETI_CHEETAH
-
-config USE_FAILOVER_IMAGE
-	bool
-	default n
-	depends on BOARD_AMD_SERENGETI_CHEETAH
-
 config MAX_CPUS
 	int
 	default 8
Index: src/mainboard/tyan/s2850/Kconfig
===================================================================
--- src/mainboard/tyan/s2850/Kconfig	(Revision 4713)
+++ src/mainboard/tyan/s2850/Kconfig	(Arbeitskopie)
@@ -39,16 +39,6 @@ 
 	default 0x100000
 	depends on BOARD_TYAN_S2850
 
-config HAVE_FAILOVER_BOOT
-	bool
-	default n
-	depends on BOARD_TYAN_S2850
-
-config USE_FAILOVER_IMAGE
-	bool
-	default n
-	depends on BOARD_TYAN_S2850
-
 config MAX_CPUS
 	int
 	default 2
Index: src/mainboard/tyan/s2881/Kconfig
===================================================================
--- src/mainboard/tyan/s2881/Kconfig	(Revision 4713)
+++ src/mainboard/tyan/s2881/Kconfig	(Arbeitskopie)
@@ -45,11 +45,6 @@ 
 	default 0x2881
 	depends on BOARD_TYAN_S2881
 
-config USE_FAILOVER_IMAGE
-	bool
-	default n
-	depends on BOARD_TYAN_S2881
-
 config HW_MEM_HOLE_SIZEK
 	hex
 	default 0x100000
@@ -60,16 +55,6 @@ 
 	default n
 	depends on BOARD_TYAN_S2881
 
-config HAVE_FAILOVER_BOOT
-	bool
-	default n
-	depends on BOARD_TYAN_S2881
-
-config USE_FAILOVER_IMAGE
-	bool
-	default n
-	depends on BOARD_TYAN_S2881
-
 config MAX_CPUS
 	int
 	default 4
Index: src/mainboard/tyan/s2891/Kconfig
===================================================================
--- src/mainboard/tyan/s2891/Kconfig	(Revision 4713)
+++ src/mainboard/tyan/s2891/Kconfig	(Arbeitskopie)
@@ -45,11 +45,6 @@ 
 	default 0x2891
 	depends on BOARD_TYAN_S2891
 
-config USE_FAILOVER_IMAGE
-	bool
-	default n
-	depends on BOARD_TYAN_S2891
-
 config HW_MEM_HOLE_SIZEK
 	hex
 	default 0x100000
@@ -60,16 +55,6 @@ 
 	default n
 	depends on BOARD_TYAN_S2891
 
-config HAVE_FAILOVER_BOOT
-	bool
-	default n
-	depends on BOARD_TYAN_S2891
-
-config USE_FAILOVER_IMAGE
-	bool
-	default n
-	depends on BOARD_TYAN_S2891
-
 config MAX_CPUS
 	int
 	default 4
Index: src/mainboard/tyan/s2892/Kconfig
===================================================================
--- src/mainboard/tyan/s2892/Kconfig	(Revision 4713)
+++ src/mainboard/tyan/s2892/Kconfig	(Arbeitskopie)
@@ -45,11 +45,6 @@ 
 	default 0x2892
 	depends on BOARD_TYAN_S2892
 
-config USE_FAILOVER_IMAGE
-	bool
-	default n
-	depends on BOARD_TYAN_S2892
-
 config HW_MEM_HOLE_SIZEK
 	hex
 	default 0x100000
@@ -60,16 +55,6 @@ 
 	default n
 	depends on BOARD_TYAN_S2892
 
-config HAVE_FAILOVER_BOOT
-	bool
-	default n
-	depends on BOARD_TYAN_S2892
-
-config USE_FAILOVER_IMAGE
-	bool
-	default n
-	depends on BOARD_TYAN_S2892
-
 config MAX_CPUS
 	int
 	default 4
Index: src/mainboard/tyan/s2875/Kconfig
===================================================================
--- src/mainboard/tyan/s2875/Kconfig	(Revision 4713)
+++ src/mainboard/tyan/s2875/Kconfig	(Arbeitskopie)
@@ -40,16 +40,6 @@ 
 	default 0x100000
 	depends on BOARD_TYAN_S2875
 
-config HAVE_FAILOVER_BOOT
-	bool
-	default n
-	depends on BOARD_TYAN_S2875
-
-config USE_FAILOVER_IMAGE
-	bool
-	default n
-	depends on BOARD_TYAN_S2875
-
 config MAX_CPUS
 	int
 	default 4
Index: src/mainboard/tyan/s2895/Kconfig
===================================================================
--- src/mainboard/tyan/s2895/Kconfig	(Revision 4713)
+++ src/mainboard/tyan/s2895/Kconfig	(Arbeitskopie)
@@ -45,11 +45,6 @@ 
 	default 0x2895
 	depends on BOARD_TYAN_S2895
 
-config USE_FAILOVER_IMAGE
-	bool
-	default n
-	depends on BOARD_TYAN_S2895
-
 config HW_MEM_HOLE_SIZEK
 	hex
 	default 0x100000
@@ -60,16 +55,6 @@ 
 	default n
 	depends on BOARD_TYAN_S2895
 
-config HAVE_FAILOVER_BOOT
-	bool
-	default n
-	depends on BOARD_TYAN_S2895
-
-config USE_FAILOVER_IMAGE
-	bool
-	default n
-	depends on BOARD_TYAN_S2895
-
 config MAX_CPUS
 	int
 	default 4
Index: src/mainboard/dell/s1850/Kconfig
===================================================================
--- src/mainboard/dell/s1850/Kconfig	(Revision 4713)
+++ src/mainboard/dell/s1850/Kconfig	(Arbeitskopie)
@@ -33,21 +33,6 @@ 
 	default 0x016c
 	depends on BOARD_DELL_S1850
 
-config USE_FAILOVER_IMAGE
-	bool
-	default n
-	depends on BOARD_DELL_S1850
-
-config HAVE_FAILOVER_BOOT
-	bool
-	default n
-	depends on BOARD_DELL_S1850
-
-config USE_FAILOVER_IMAGE
-	bool
-	default n
-	depends on BOARD_DELL_S1850
-
 config MAX_CPUS
 	int
 	default 2
Index: src/mainboard/sunw/ultra40/Kconfig
===================================================================
--- src/mainboard/sunw/ultra40/Kconfig	(Revision 4713)
+++ src/mainboard/sunw/ultra40/Kconfig	(Arbeitskopie)
@@ -76,16 +76,6 @@ 
 	default 0x100000
 	depends on BOARD_SUNW_ULTRA40
 
-config HAVE_FAILOVER_BOOT
-	bool
-	default n
-	depends on BOARD_SUNW_ULTRA40
-
-config USE_FAILOVER_IMAGE
-	bool
-	default n
-	depends on BOARD_SUNW_ULTRA40
-
 config MAX_CPUS
 	int
 	default 4