Patchwork A8M2N-LA fail

login
register
about
Submitter Stefan Tauner
Date 2011-08-05 13:05:35
Message ID <201108051306.p75D6YF0025300@mail2.student.tuwien.ac.at>
Download mbox | patch
Permalink /patch/3332/
State Accepted
Commit r1408
Headers show

Comments

Stefan Tauner - 2011-08-05 13:05:35
hi again

can you please try the attached patch to write to your board (please do
a backup with ./flashrom -r backup.bin first)?
if it does not work please also apply
http://patchwork.coreboot.org/patch/2125/raw/
and try again.

if you have any questions regarding the patching (or building) process
please ask. you can also reach us on freenode's IRC in #flashrom.

PS: i have attached the log files márton has sent me for further
reference too.
Márton Miklós - 2011-08-05 16:00:22
Hello,

I did not found how should I apply the pacth to a freshly checkouted svn 
trunk,
so I have applied it manually in gedit, and the BIOS writing done 
successfully.
Thank you very much for the support and help!
You have done a great job with the flashrom!

Regards,
Miklós

2011-08-05 15:05 keltezéssel, Stefan Tauner írta:
> hi again
>
> can you please try the attached patch to write to your board (please do
> a backup with ./flashrom -r backup.bin first)?
> if it does not work please also apply
> http://patchwork.coreboot.org/patch/2125/raw/
> and try again.
>
> if you have any questions regarding the patching (or building) process
> please ask. you can also reach us on freenode's IRC in #flashrom.
>
> PS: i have attached the log files márton has sent me for further
> reference too.
Stefan Tauner - 2011-08-07 13:20:16
On Fri, 05 Aug 2011 18:00:22 +0200
Márton Miklós <martonmiklosqdev@gmail.com> wrote:

> Hello,
> 
> I did not found how should I apply the pacth to a freshly checkouted svn 
> trunk,
> so I have applied it manually in gedit, and the BIOS writing done 
> successfully.
> Thank you very much for the support and help!
> You have done a great job with the flashrom!
> 

Hi Miklós

the usual way to apply patches is with the "patch" program:
cd srcdir
patch < patchfile.patch
(the most often used parameter for patch is -p, see man page if you
ever need it again please)

thanks for testing, i have committed the board enable in r1408.

Patch

From 93428d1a7d19b0055aea3c1d8b439cf865ac5bb1 Mon Sep 17 00:00:00 2001
From: Stefan Tauner <stefan.tauner@student.tuwien.ac.at>
Date: Fri, 5 Aug 2011 14:55:10 +0200
Subject: [PATCH] Add a board enable for ASUS A8M2N-LA (HP OEM "NodusM3-GL8E")
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

based on Joshua Roys' RE

Signed-off-by: Stefan Tauner <stefan.tauner@student.tuwien.ac.at>
---
 board_enable.c   |    2 ++
 chipset_enable.c |    2 +-
 print.c          |    1 +
 3 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/board_enable.c b/board_enable.c
index 3f4c66a..e284ccc 100644
--- a/board_enable.c
+++ b/board_enable.c
@@ -921,6 +921,7 @@  static int nvidia_mcp_gpio_set(int gpio, int raise)
 
 /*
  * Suited for:
+ *  - ASUS A8M2N-LA (HP OEM "NodusM3-GL8E"): NVIDIA MCP51
  *  - ASUS A8N-LA (HP OEM "Nagami-GL8E"): NVIDIA MCP51
  *  - ASUS M2NBP-VM CSM: NVIDIA MCP51
  */
@@ -2000,6 +2001,7 @@  const struct board_pciid_enable board_pciid_enables[] = {
 	{0x1106, 0x3189, 0x1043, 0x807F,  0x1106, 0x3177, 0x1043, 0x80A1, NULL,         NULL, NULL,           P3, "ASUS",        "A7V8X-X",               0,   OK, it8712f_gpio3_1_raise},
 	{0x1002, 0x4372, 0x103c, 0x2a26,  0x1002, 0x4377, 0x103c, 0x2a26, NULL,         NULL, NULL,           P3, "ASUS",        "A8AE-LE",               0,   OK, amd_sbxxx_gpio9_raise},
 	{0x8086, 0x27A0, 0x1043, 0x1287,  0x8086, 0x27DF, 0x1043, 0x1287, "^A8J",       NULL, NULL,           P3, "ASUS",        "A8Jm",                  0,   NT, intel_ich_gpio34_raise},
+	{0x10DE, 0x0260, 0x103C, 0x2A34,  0x10DE, 0x0264, 0x103C, 0x2A34, "NODUSM3",    NULL, NULL,           P3, "ASUS",        "A8M2N-LA (NodusM3-GL8E)",  0,   OK, nvidia_mcp_gpio0_raise},
 	{0x10DE, 0x0260, 0x103c, 0x2a3e,  0x10DE, 0x0264, 0x103c, 0x2a3e, "NAGAMI2L",   NULL, NULL,           P3, "ASUS",        "A8N-LA (Nagami-GL8E)",  0,   OK, nvidia_mcp_gpio0_raise},
 	{0x10DE, 0x005E, 0x1043, 0x815A,  0x10DE, 0x0054, 0x1043, 0x815A, "^A8N-SLI",   NULL, NULL,           P3, "ASUS",        "A8N-SLI Deluxe",        0,   NT, board_shuttle_fn25},
 	{0x10de, 0x0264, 0x1043, 0x81bc,  0x10de, 0x02f0, 0x1043, 0x81cd, NULL,         NULL, NULL,           P3, "ASUS",        "A8N-VM CSM",            0,   OK, w83627ehf_gpio22_raise_2e},
diff --git a/chipset_enable.c b/chipset_enable.c
index 97001a7..b4ec96b 100644
--- a/chipset_enable.c
+++ b/chipset_enable.c
@@ -1096,7 +1096,7 @@  const struct penable chipset_enables[] = {
 	{0x10de, 0x00e0, OK, "NVIDIA", "NForce3",	enable_flash_nvidia_nforce2},
 	/* Slave, should not be here, to fix known bug for A01. */
 	{0x10de, 0x00d3, OK, "NVIDIA", "CK804",		enable_flash_ck804},
-	{0x10de, 0x0260, NT, "NVIDIA", "MCP51",		enable_flash_ck804},
+	{0x10de, 0x0260, OK, "NVIDIA", "MCP51",		enable_flash_ck804},
 	{0x10de, 0x0261, NT, "NVIDIA", "MCP51",		enable_flash_ck804},
 	{0x10de, 0x0262, NT, "NVIDIA", "MCP51",		enable_flash_ck804},
 	{0x10de, 0x0263, NT, "NVIDIA", "MCP51",		enable_flash_ck804},
diff --git a/print.c b/print.c
index b72aea8..eb7252b 100644
--- a/print.c
+++ b/print.c
@@ -420,6 +420,7 @@  const struct board_info boards_known[] = {
 	B("ASUS",	"A7V8X-MX SE",		1, "http://www.asus.com/product.aspx?P_ID=1guVBT1qV5oqhHyZ", NULL),
 	B("ASUS",	"A7V8X-X",		1, "http://www.asus.com/product.aspx?P_ID=YcXfRrWHZ9RKoVmw", NULL),
 	B("ASUS",	"A8Jm",			1, "http://www.asus.com/product.aspx?P_ID=VztICtOgiU6drx4m", NULL),
+	B("ASUS",	"A8M2N-LA (NodusM3-GL8E)",	1, "http://h10010.www1.hp.com/ewfrf/wc/document?docname=c00757531&cc=us&dlc=en&lc=en", "This is an OEM board from HP, the HP name is NodusM3-GL8E."),
 	B("ASUS",	"A8N",			1, NULL, NULL), /* TODO: This should probably be A8N-SLI Deluxe, see http://www.coreboot.org/pipermail/flashrom/2009-November/000878.html */
 	B("ASUS",	"A8N-E",		1, "http://www.asus.com/product.aspx?P_ID=DzbA8hgqchMBOVRz", NULL),
 	B("ASUS",	"A8N-LA (Nagami-GL8E)",	1, "http://h10025.www1.hp.com/ewfrf/wc/document?lc=en&cc=us&docname=c00647121&dlc=en", "This is an OEM board from HP, the HP name is Nagami-GL8E."),
-- 
1.7.1