Submitter | Stefan Tauner |
---|---|
Date | 2011-08-25 08:55:43 |
Message ID | <1314262543-21027-1-git-send-email-stefan.tauner@student.tuwien.ac.at> |
Download | mbox | patch |
Permalink | /patch/3392/ |
State | Accepted |
Commit | r1419 |
Headers | show |
Comments
2011/8/25 Stefan Tauner <stefan.tauner@student.tuwien.ac.at>: > Based on the REing of Michael Karcher The result can be found here: http://www.coreboot.org/pipermail/flashrom/2010-August/004500.html > and a good guess of Idwer Vollering. > > Tested-by: Leon Zhang <leoncamel at gmail.com> > Tested-by: medhi Tested-by: medhi <nefkongo@hotmail.com> Acked-by: Idwer Vollering <vidwer@gmail.com> > --- > i have added the DMI match and changed the board enable and wiki comments > a bit. i am not sure if this is the right way to add it, because there are so many > variations, but we can change that later too. > > Signed-off-by: Stefan Tauner <stefan.tauner@student.tuwien.ac.at> > --- > board_enable.c | 5 +++++ > print.c | 1 + > 2 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/board_enable.c b/board_enable.c > index b362b54..0f2300c 100644 > --- a/board_enable.c > +++ b/board_enable.c > @@ -1517,6 +1517,9 @@ static int intel_ich_gpio22_raise(void) > /* > * Suited for: > * - ASUS A8Jm (laptop): Intel 945 + ICH7 > + * - ASUS P5LP-LE used in ... > + * - HP Media Center m7270.fr Desktop PC as "Lithium-UL8E" > + * - Epson Endeavor MT7700 > */ > static int intel_ich_gpio34_raise(void) > { > @@ -2024,6 +2027,8 @@ const struct board_pciid_enable board_pciid_enables[] = { > {0x8086, 0x266a, 0x1043, 0x80a6, 0x8086, 0x2668, 0x1043, 0x814e, NULL, NULL, NULL, P3, "ASUS", "P5GD1 Pro", 0, OK, intel_ich_gpio21_raise}, > {0x8086, 0x266a, 0x1043, 0x80a6, 0x8086, 0x2668, 0x1043, 0x813d, "^P5GD2-Premium$", NULL, NULL, P3, "ASUS", "P5GD2 Premium", 0, OK, intel_ich_gpio21_raise}, > {0x8086, 0x266a, 0x1043, 0x80a6, 0x8086, 0x2668, 0x1043, 0x813d, NULL, NULL, NULL, P3, "ASUS", "P5GDC Deluxe", 0, OK, intel_ich_gpio21_raise}, > + {0x8086, 0x27b8, 0x103c, 0x2a22, 0x8086, 0x2770, 0x103c, 0x2a22, "^LITHIUM$", NULL, NULL, P3, "ASUS", "P5LP-LE", 0, OK, intel_ich_gpio34_raise}, > + {0x8086, 0x27b8, 0x1043, 0x2a22, 0x8086, 0x2770, 0x1043, 0x2a22, "^P5LP-LE$", NULL, NULL, P3, "ASUS", "P5LP-LE", 0, OK, intel_ich_gpio34_raise}, > {0x8086, 0x27da, 0x1043, 0x8179, 0x8086, 0x27b8, 0x1043, 0x8179, "^P5LD2$", NULL, NULL, P3, "ASUS", "P5LD2", 0, NT, intel_ich_gpio16_raise}, > {0x10DE, 0x0030, 0x1043, 0x818a, 0x8086, 0x100E, 0x1043, 0x80EE, NULL, NULL, NULL, P3, "ASUS", "P5ND2-SLI Deluxe", 0, OK, nvidia_mcp_gpio10_raise}, > {0x8086, 0x24dd, 0x1043, 0x80a6, 0x8086, 0x2570, 0x1043, 0x8157, NULL, NULL, NULL, P3, "ASUS", "P5PE-VM", 0, OK, intel_ich_gpio21_raise}, > diff --git a/print.c b/print.c > index c25cb3e..42e031a 100644 > --- a/print.c > +++ b/print.c > @@ -483,6 +483,7 @@ const struct board_info boards_known[] = { > B("ASUS", "P5KC", 1, "http://www.asus.com/product.aspx?P_ID=fFZ8oUIGmLpwNMjj", NULL), > B("ASUS", "P5L-MX", 1, "http://www.asus.com/product.aspx?P_ID=X70d3NCzH2DE9vWH", NULL), > B("ASUS", "P5LD2", 0, NULL, "Untested board enable."), > + B("ASUS", "P5LP-LE", 1, "http://h10025.www1.hp.com/ewfrf/wc/document?docname=c00379616&tmp_task=prodinfoCategory&cc=us&dlc=en&lc=en&product=1159887", "This is an OEM board from HP and Epson (Endeavor MT7700). The HP names vary and not all of them were tested."), > B("ASUS", "P5GD1 Pro", 1, "http://www.asus.com/product.aspx?P_ID=50M49xQh71EZOeM1", NULL), > B("ASUS", "P5N-E SLI", 0, "http://www.asus.com/product.aspx?P_ID=KyHOsOKWujC2QguJ", "Needs a board enable (http://patchwork.coreboot.org/patch/3298/)."), > B("ASUS", "P5N32-E SLI", 1, "http://www.asus.com/product.aspx?P_ID=vBZLIBtPzYB2bLcb", NULL), > -- > 1.7.1 > > > _______________________________________________ > flashrom mailing list > flashrom@flashrom.org > http://www.flashrom.org/mailman/listinfo/flashrom >
On Thu, 25 Aug 2011 14:19:33 +0200
Idwer Vollering <vidwer@gmail.com> wrote:
> Acked-by: Idwer Vollering <vidwer@gmail.com>
r1419, thanks.
i have changed it a bit though: i had to rename the board names of the
board enable, because the print.c code is not able to cope with
multiple boards with the same name, resulting in output like:
ASUS P5LP-LE OK (autodetected)(autodetected)
i hope everyone can live with the result :)
Patch
diff --git a/board_enable.c b/board_enable.c index b362b54..0f2300c 100644 --- a/board_enable.c +++ b/board_enable.c @@ -1517,6 +1517,9 @@ static int intel_ich_gpio22_raise(void) /* * Suited for: * - ASUS A8Jm (laptop): Intel 945 + ICH7 + * - ASUS P5LP-LE used in ... + * - HP Media Center m7270.fr Desktop PC as "Lithium-UL8E" + * - Epson Endeavor MT7700 */ static int intel_ich_gpio34_raise(void) { @@ -2024,6 +2027,8 @@ const struct board_pciid_enable board_pciid_enables[] = { {0x8086, 0x266a, 0x1043, 0x80a6, 0x8086, 0x2668, 0x1043, 0x814e, NULL, NULL, NULL, P3, "ASUS", "P5GD1 Pro", 0, OK, intel_ich_gpio21_raise}, {0x8086, 0x266a, 0x1043, 0x80a6, 0x8086, 0x2668, 0x1043, 0x813d, "^P5GD2-Premium$", NULL, NULL, P3, "ASUS", "P5GD2 Premium", 0, OK, intel_ich_gpio21_raise}, {0x8086, 0x266a, 0x1043, 0x80a6, 0x8086, 0x2668, 0x1043, 0x813d, NULL, NULL, NULL, P3, "ASUS", "P5GDC Deluxe", 0, OK, intel_ich_gpio21_raise}, + {0x8086, 0x27b8, 0x103c, 0x2a22, 0x8086, 0x2770, 0x103c, 0x2a22, "^LITHIUM$", NULL, NULL, P3, "ASUS", "P5LP-LE", 0, OK, intel_ich_gpio34_raise}, + {0x8086, 0x27b8, 0x1043, 0x2a22, 0x8086, 0x2770, 0x1043, 0x2a22, "^P5LP-LE$", NULL, NULL, P3, "ASUS", "P5LP-LE", 0, OK, intel_ich_gpio34_raise}, {0x8086, 0x27da, 0x1043, 0x8179, 0x8086, 0x27b8, 0x1043, 0x8179, "^P5LD2$", NULL, NULL, P3, "ASUS", "P5LD2", 0, NT, intel_ich_gpio16_raise}, {0x10DE, 0x0030, 0x1043, 0x818a, 0x8086, 0x100E, 0x1043, 0x80EE, NULL, NULL, NULL, P3, "ASUS", "P5ND2-SLI Deluxe", 0, OK, nvidia_mcp_gpio10_raise}, {0x8086, 0x24dd, 0x1043, 0x80a6, 0x8086, 0x2570, 0x1043, 0x8157, NULL, NULL, NULL, P3, "ASUS", "P5PE-VM", 0, OK, intel_ich_gpio21_raise}, diff --git a/print.c b/print.c index c25cb3e..42e031a 100644 --- a/print.c +++ b/print.c @@ -483,6 +483,7 @@ const struct board_info boards_known[] = { B("ASUS", "P5KC", 1, "http://www.asus.com/product.aspx?P_ID=fFZ8oUIGmLpwNMjj", NULL), B("ASUS", "P5L-MX", 1, "http://www.asus.com/product.aspx?P_ID=X70d3NCzH2DE9vWH", NULL), B("ASUS", "P5LD2", 0, NULL, "Untested board enable."), + B("ASUS", "P5LP-LE", 1, "http://h10025.www1.hp.com/ewfrf/wc/document?docname=c00379616&tmp_task=prodinfoCategory&cc=us&dlc=en&lc=en&product=1159887", "This is an OEM board from HP and Epson (Endeavor MT7700). The HP names vary and not all of them were tested."), B("ASUS", "P5GD1 Pro", 1, "http://www.asus.com/product.aspx?P_ID=50M49xQh71EZOeM1", NULL), B("ASUS", "P5N-E SLI", 0, "http://www.asus.com/product.aspx?P_ID=KyHOsOKWujC2QguJ", "Needs a board enable (http://patchwork.coreboot.org/patch/3298/)."), B("ASUS", "P5N32-E SLI", 1, "http://www.asus.com/product.aspx?P_ID=vBZLIBtPzYB2bLcb", NULL),