Patchwork [PATCHes] more kconfig stuff

login
register
about
Submitter Myles Watson
Date 2009-10-07 15:17:21
Message ID <2831fecf0910070817m794fb0cej74f3c7b5b6057587@mail.gmail.com>
Download mbox | patch
Permalink /patch/359/
State Accepted
Headers show

Comments

Myles Watson - 2009-10-07 15:17:21
On Wed, Oct 7, 2009 at 9:04 AM, Patrick Georgi <patrick@georgi-clan.de> wrote:
> Hi,
>
> more kconfig patches:
>
> 20091007-2-kconfig-amd-socket-754
> implements Kconfig support for AMDs Socket 754
>
> 20091007-3-kconfig-mcp55-romstrap
> adds the romstrap include for MCP55 boards
Good find.

> 20091007-4-kconfig-msi-boards
> implements the remaining MSI boards.


I like the reuse.  Maybe it's time to rename that file and move it
somewhere more general.

>
> Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Myles Watson <mylesgw@gmail.com>

Thanks,
Myles
Peter Stuge - 2009-10-07 17:55:25
Myles Watson wrote:
> +++ src/mainboard/msi/ms7135/Makefile.inc	(Revision 0)
> @@ -0,0 +1 @@
> +include $(src)/mainboard/tyan/Makefile.s289x.inc
> 
> I like the reuse.

Indeed.


> Maybe it's time to rename that file and move it somewhere more
> general.

Makes sense. Now where to put it might be more tricky. It depends on
how generic the file is.

Maybe just add a top level mainboard_includes and use good filenames
in there?


//Peter
Patrick Georgi - 2009-10-07 18:03:56
Am Mittwoch, den 07.10.2009, 19:55 +0200 schrieb Peter Stuge:
> Makes sense. Now where to put it might be more tricky. It depends on
> how generic the file is.
The file is - strictly speaking - only suitable for ck804 boards.
There's a simple trick to clean this up, so I didn't bother too much
about it.

> Maybe just add a top level mainboard_includes and use good filenames
> in there?
Please don't put too much effort into placing these files
(Makefile.romccboard.inc, too) at the "right" location. If everything
works out, their content ends up - much more generic - in the top-level
Makefile.

I recorded some notes on the Kconfig wiki page.


Thanks,
Patrick

Patch

===================================================================
--- src/mainboard/msi/ms7135/Makefile.inc	(Revision 0)
+++ src/mainboard/msi/ms7135/Makefile.inc	(Revision 0)
@@ -0,0 +1 @@ 
+include $(src)/mainboard/tyan/Makefile.s289x.inc