Patchwork =?utf8?q?=5BPATCH_2/2=5D_Add_board_enable_for_Biostar_?= =?utf8?q?M7VIQ=2E?=

login
register
about
Submitter Stefan Tauner
Date 2012-04-27 23:30:53
Message ID <1335569453-19086-2-git-send-email-stefan.tauner@student.tuwien.ac.at>
Download mbox | patch
Permalink /patch/3610/
State Accepted
Commit r1566
Headers show

Comments

Stefan Tauner - 2012-04-27 23:30:53
The PCI IDs are generic VIA IDs. Only Biostar IDs are those of the LOM, but
that would not be a good choice for ID. Accept the generic IDs (+ DMI string)
for now because this will be generic soonish(tm) anyway.

Signed-off-by: Stefan Tauner <stefan.tauner@student.tuwien.ac.at>
---
 board_enable.c |   13 +++++++++++++
 print.c        |    2 +-
 2 files changed, 14 insertions(+), 1 deletion(-)
Luc Verhaegen - 2012-04-27 23:42:37
On Sat, Apr 28, 2012 at 01:30:53AM +0200, Stefan Tauner wrote:
> The PCI IDs are generic VIA IDs. Only Biostar IDs are those of the LOM, but
> that would not be a good choice for ID. Accept the generic IDs (+ DMI string)
> for now because this will be generic soonish(tm) anyway.

> +	{0x1106, 0x3177, 0x1106, 0x3177,  0x1106, 0x3116, 0x1106, 0x3116, "^KM266-8235$", NULL, NULL,         P3, "Biostar",     "M7VIQ",                 0,   OK, w83697xx_memw_enable_2e},

"KM266-8235" is "VIA Northbridge marketing name"-"VIA Southbridge 
marketing name with VT removed".

This DMI string is not unique at all.

Luc Verhaegen.
Stefan Tauner - 2012-04-28 00:06:48
On Sat, 28 Apr 2012 01:42:37 +0200
Luc Verhaegen <libv@skynet.be> wrote:

> On Sat, Apr 28, 2012 at 01:30:53AM +0200, Stefan Tauner wrote:
> > The PCI IDs are generic VIA IDs. Only Biostar IDs are those of the LOM, but
> > that would not be a good choice for ID. Accept the generic IDs (+ DMI string)
> > for now because this will be generic soonish(tm) anyway.
> 
> > +	{0x1106, 0x3177, 0x1106, 0x3177,  0x1106, 0x3116, 0x1106, 0x3116, "^KM266-8235$", NULL, NULL,         P3, "Biostar",     "M7VIQ",                 0,   OK, w83697xx_memw_enable_2e},
> 
> "KM266-8235" is "VIA Northbridge marketing name"-"VIA Southbridge 
> marketing name with VT removed".
> 
> This DMI string is not unique at all.

true, yet there is no real alternative and a rationale was given to why
it does not really matter much anyway. just ranting does not really
help in this case :)
Luc Verhaegen - 2012-04-28 00:25:02
On Sat, Apr 28, 2012 at 02:06:48AM +0200, Stefan Tauner wrote:
> On Sat, 28 Apr 2012 01:42:37 +0200
> Luc Verhaegen <libv@skynet.be> wrote:
> 
> > On Sat, Apr 28, 2012 at 01:30:53AM +0200, Stefan Tauner wrote:
> > > The PCI IDs are generic VIA IDs. Only Biostar IDs are those of the LOM, but
> > > that would not be a good choice for ID. Accept the generic IDs (+ DMI string)
> > > for now because this will be generic soonish(tm) anyway.
> > 
> > > +	{0x1106, 0x3177, 0x1106, 0x3177,  0x1106, 0x3116, 0x1106, 0x3116, "^KM266-8235$", NULL, NULL,         P3, "Biostar",     "M7VIQ",                 0,   OK, w83697xx_memw_enable_2e},
> > 
> > "KM266-8235" is "VIA Northbridge marketing name"-"VIA Southbridge 
> > marketing name with VT removed".
> > 
> > This DMI string is not unique at all.
> 
> true, yet there is no real alternative and a rationale was given to why
> it does not really matter much anyway. just ranting does not really
> help in this case :)
> 

Surely a specific board name can still be provided on the command line
for horribly broken bioses like this?

Luc Verhaegen.
Stefan Tauner - 2012-04-28 10:50:19
On Sat, 28 Apr 2012 02:25:02 +0200
Luc Verhaegen <libv@skynet.be> wrote:

> Surely a specific board name can still be provided on the command line
> for horribly broken bioses like this?

yes, thanks for the suggestion. apparently i forgot that alternative.
Luc Verhaegen - 2012-04-28 10:59:59
On Sat, Apr 28, 2012 at 12:50:19PM +0200, Stefan Tauner wrote:
> On Sat, 28 Apr 2012 02:25:02 +0200
> Luc Verhaegen <libv@skynet.be> wrote:
> 
> > Surely a specific board name can still be provided on the command line
> > for horribly broken bioses like this?
> 
> yes, thanks for the suggestion. apparently i forgot that alternative.
> 

I am not sure anymore how much information one has to provide still 
though, it's been quite a while. I think pci device ids only, no board 
ids, so that not every command line provided board name is accepted.

Luc Verhaegen.
Stefan Tauner - 2012-08-09 23:42:38
On Sat, 28 Apr 2012 12:59:59 +0200
Luc Verhaegen <libv@skynet.be> wrote:

> On Sat, Apr 28, 2012 at 12:50:19PM +0200, Stefan Tauner wrote:
> > On Sat, 28 Apr 2012 02:25:02 +0200
> > Luc Verhaegen <libv@skynet.be> wrote:
> > 
> > > Surely a specific board name can still be provided on the command line
> > > for horribly broken bioses like this?
> > 
> > yes, thanks for the suggestion. apparently i forgot that alternative.

i have committed the resulting board enable patch in r1566.

> I am not sure anymore how much information one has to provide still 
> though, it's been quite a while. I think pci device ids only, no board 
> ids, so that not every command line provided board name is accepted.

device ids are mandatory, subsystem ids are not checked atm
(for non-autodetected boards), but i have left them in anyway.
the dmi string is also not checked at all in this case... ill take a
look at refactoring the involved functions and the looooong comment
explaining all that soon-ish.

Patch

diff --git a/board_enable.c b/board_enable.c
index 8f01fc1..6221575 100644
--- a/board_enable.c
+++ b/board_enable.c
@@ -415,6 +415,18 @@  static void w83697xx_memw_enable(uint16_t port)
 
 /*
  * Suited for:
+ *  - Biostar M7VIQ: VIA KM266 + VT8235
+ */
+static int w83697xx_memw_enable_2e(void)
+{
+	w83697xx_memw_enable(0x2E);
+
+	return 0;
+}
+
+
+/*
+ * Suited for:
  *  - EPoX EP-8K5A2: VIA KT333 + VT8235
  *  - Albatron PM266A Pro: VIA P4M266A + VT8235
  *  - Shuttle AK31 (all versions): VIA KT266 + VT8233
@@ -2208,6 +2220,7 @@  const struct board_match board_matches[] = {
 	{0x10DE, 0x0260, 0x1043, 0x81BC,  0x10DE, 0x026C, 0x1043, 0x8249, "^P5N-E SLI$",NULL, NULL,           P3, "ASUS",        "P5N-E SLI",             0,   NT, it8718f_gpio63_raise},
 	{0x8086, 0x24dd, 0x1043, 0x80a6,  0x8086, 0x2570, 0x1043, 0x8157, NULL,         NULL, NULL,           P3, "ASUS",        "P5PE-VM",               0,   OK, intel_ich_gpio21_raise},
 	{0x8086, 0x2443, 0x1043, 0x8027,  0x8086, 0x1130, 0x1043, 0x8027, NULL,         NULL, NULL,           P3, "ASUS",        "TUSL2-C",               0,   NT, intel_ich_gpio21_raise},
+	{0x1106, 0x3177, 0x1106, 0x3177,  0x1106, 0x3116, 0x1106, 0x3116, "^KM266-8235$", NULL, NULL,         P3, "Biostar",     "M7VIQ",                 0,   OK, w83697xx_memw_enable_2e},
 	{0x10b7, 0x9055, 0x1028, 0x0082,  0x8086, 0x7190,      0,      0, NULL,         NULL, NULL,           P3, "Dell",        "OptiPlex GX1",          0,   OK, intel_piix4_gpo30_lower},
 	{0x8086, 0x3590, 0x1028, 0x016c,  0x1000, 0x0030, 0x1028, 0x016c, NULL,         NULL, NULL,           P3, "Dell",        "PowerEdge 1850",        0,   OK, intel_ich_gpio23_raise},
 	{0x10de, 0x03ea, 0x1019, 0x2602,  0x10de, 0x03e0, 0x1019, 0x2602, NULL,         NULL, NULL,           P3, "Elitegroup",  "GeForce6100SM-M",       0,   OK, board_ecs_geforce6100sm_m},
diff --git a/print.c b/print.c
index 84a1604..4706589 100644
--- a/print.c
+++ b/print.c
@@ -721,7 +721,7 @@  const struct board_info boards_known[] = {
 	B("Biostar",	"H61MU3",		0, NULL, "Probing works (Eon EN25Q32(A/B), 4096 kB, SPI), but parts of the flash are problematic: descriptor is r/o (conforming to ICH reqs), ME region is locked."),
 	B("Biostar",	"M6TBA",		0, "ftp://ftp.biostar-usa.com/manuals/M6TBA/", "No public report found. Owned by Uwe Hermann <uwe@hermann-uwe.de>. May work now."),
 	B("Biostar",	"M7NCD Pro",		1, "http://www.biostar.com.tw/app/en/mb/content.php?S_ID=260", NULL),
-	B("Biostar",	"M7VIQ",		0, NULL, "Missing board enable (W83697HF/F/HG/G), see http://www.flashrom.org/pipermail/flashrom/2012-February/008863.html"),
+	B("Biostar",	"M7VIQ",		1, NULL, NULL),
 	B("Biostar",	"N61PB-M2S",		1, NULL, NULL),
 	B("Biostar",	"N68S3+",		1, NULL, NULL),
 	B("Biostar",	"P4M80-M4",		1, "http://www.biostar-usa.com/mbdetails.asp?model=p4m80-m4", NULL),