Patchwork patch: failover.inc may need mmx enabled with some romcc options

login
register
about
Submitter ron minnich
Date 2009-10-07 22:50:52
Message ID <13426df10910071550i616078c6me94dad16645da517@mail.gmail.com>
Download mbox | patch
Permalink /patch/365/
State Accepted
Headers show

Comments

ron minnich - 2009-10-07 22:50:52
so move failover.inc after the mmx setup. This is definitely an issue
in the s1850; seperate patch coming.

Can someone test this patch please?

ron

Patch

This may not be a problem yet. But failover.inc, when used with the 
right romcc options, will need mmx (and in future SSE) to be set up.
Move it to the right place. 

Can someone please test. 

Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Index: src/mainboard/Makefile.romccboard.inc
===================================================================
--- src/mainboard/Makefile.romccboard.inc	(revision 4735)
+++ src/mainboard/Makefile.romccboard.inc	(working copy)
@@ -24,15 +24,16 @@ 
 crt0-y += ../../../../src/cpu/x86/16bit/reset16.inc
 crt0-y += ../../../../src/arch/i386/lib/cpu_reset.inc
 crt0-y += ../../../../src/arch/i386/lib/id.inc
-crt0-y += failover.inc
 crt0-y += ../../../../src/cpu/x86/fpu/enable_fpu.inc
 
 ifeq ($(CONFIG_CPU_AMD_GX1),y)
 crt0-y += ../../../../src/cpu/amd/model_gx1/cpu_setup.inc
 crt0-y += ../../../../src/cpu/amd/model_gx1/gx_setup.inc
+crt0-y += failover.inc
 crt0-y += auto.inc
 else
 crt0-y += ../../../../src/cpu/x86/mmx/enable_mmx.inc
+crt0-y += failover.inc
 crt0-y += auto.inc
 crt0-y += ../../../../src/cpu/x86/mmx/disable_mmx.inc
 endif