Patchwork annotate Numonyx/Micron N25Q064

login
register
about
Submitter David Hendricks
Date 2012-07-24 22:17:02
Message ID <CAKOoyUfGcvk2g7r4JezZrCju=A62E9pXwOuv9BW+zZ9-5yMgtw@mail.gmail.com>
Download mbox | patch
Permalink /patch/3696/
State Accepted
Headers show

Comments

David Hendricks - 2012-07-24 22:17:02
This adds the following:
- missing feature_bits to indicate WREN required before WRSR and the
presence of OTP bytes
- a comment mentioning SFDP support
- voltage range

Signed-off-by: David Hendricks <dhendrix@google.com>
Stefan Tauner - 2012-07-25 01:27:49
On Tue, 24 Jul 2012 15:17:02 -0700
David Hendricks <dhendrix@google.com> wrote:

> This adds the following:
> - missing feature_bits to indicate WREN required before WRSR and the
> presence of OTP bytes
> - a comment mentioning SFDP support
> - voltage range
> 
> Signed-off-by: David Hendricks <dhendrix@google.com>
Acked-by: Stefan Tauner <stefan.tauner@student.tuwien.ac.at>

Thanks for that! i'll commit it in my tested_stuff branch (soon-ish).

Patch

Index: flashchips.c
===================================================================
--- flashchips.c        (revision 1553)
+++ flashchips.c        (working copy)
@@ -5431,6 +5431,9 @@ 
                .model_id       = ST_N25Q064,
                .total_size     = 8192,
                .page_size      = 256,
+               /* supports SFDP */
+               /* OTP: 64B total; read 0x4B, write 0x42 */
+               .feature_bits   = FEATURE_WRSR_WREN | FEATURE_OTP,
                .tested         = TEST_OK_PREW,
                .probe          = probe_spi_rdid,
                .probe_timing   = TIMING_ZERO,
@@ -5450,6 +5453,7 @@ 
                .unlock         = spi_disable_blockprotect,
                .write          = spi_chip_write_256,
                .read           = spi_chip_read,
+               .voltage        = {2700, 3600},
        },

        {