Patchwork CONFIG_DEFAULT setting

login
register
about
Submitter Carl-Daniel Hailfinger
Date 2012-11-20 23:07:40
Message ID <50AC0D3C.6050408@gmx.net>
Download mbox | patch
Permalink /patch/3795/
State Deferred
Headers show

Comments

Carl-Daniel Hailfinger - 2012-11-20 23:07:40
Allow easy disabling of all programmers except selected ones by setting
CONFIG_DEFAULT=no.
Setting CONFIG_DEFAULT=yes has no effect.

Usage example:
# make CONFIG_DUMMY=yes CONFIG_NIC3COM=yes CONFIG_DEFAULT=no
This will disable all programmers except dummy and nic3com.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Stefan Tauner - 2013-06-01 12:21:52
On Wed, 21 Nov 2012 00:07:40 +0100
Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> wrote:

> +# This parameter picks the default setting for CONFIG_ variables of programmers not specified explicitly
> +# on the command line.
> +CONFIG_DEFAULT ?= yes

i dont like "picks" in there. whats wrong with configures, selects,
sets? :)

also, i would rename CONFIG_DEFAULT because it is not specific enough.
e.g. there is also CONFIG_PRINT_WIKI which is not (and should not be)
affected by this setting. i propose CONFIG_PROGRAMMER_DEFAULT_STATE.
yes, that is awfully long, but much clearer. a part of the problem is
that we already have a CONFIG_DEFAULT_PROGRAMMER that we need to keep
recognizably different.

>  # Disable Dediprog SF100 until support is complete and tested.
>  CONFIG_DEDIPROG ?= no
>  [etc]

whats the rationale to exclude those? IMHO it makes sense to enable them
too with CONFIG_DEFAULT.
Stefan Tauner - 2013-09-14 09:46:17
On Sat, 1 Jun 2013 14:21:52 +0200
Stefan Tauner <stefan.tauner@student.tuwien.ac.at> wrote:

> On Wed, 21 Nov 2012 00:07:40 +0100
> Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> wrote:
> 
> > +# This parameter picks the default setting for CONFIG_ variables of programmers not specified explicitly
> > +# on the command line.
> > +CONFIG_DEFAULT ?= yes
> 
> i dont like "picks" in there. whats wrong with configures, selects,
> sets? :)
> 
> also, i would rename CONFIG_DEFAULT because it is not specific enough.
> e.g. there is also CONFIG_PRINT_WIKI which is not (and should not be)
> affected by this setting. i propose CONFIG_PROGRAMMER_DEFAULT_STATE.
> yes, that is awfully long, but much clearer. a part of the problem is
> that we already have a CONFIG_DEFAULT_PROGRAMMER that we need to keep
> recognizably different.
> 
> >  # Disable Dediprog SF100 until support is complete and tested.
> >  CONFIG_DEDIPROG ?= no
> >  [etc]
> 
> whats the rationale to exclude those? IMHO it makes sense to enable them
> too with CONFIG_DEFAULT.

ping, I want this in. Even with the controversial points above.
If I dont hear back from you, Ill rebase, change according to my
comments above and commit.

Patch

Index: flashrom-Makefile_config_default/Makefile
===================================================================
--- flashrom-Makefile_config_default/Makefile	(Revision 1623)
+++ flashrom-Makefile_config_default/Makefile	(Arbeitskopie)
@@ -52,6 +52,10 @@ 
 # Compilation will fail for unspecified values.
 CONFIG_DEFAULT_PROGRAMMER ?= PROGRAMMER_INVALID
 
+# This parameter picks the default setting for CONFIG_ variables of programmers not specified explicitly
+# on the command line.
+CONFIG_DEFAULT ?= yes
+
 # If your compiler spits out excessive warnings, run make WARNERROR=no
 # You shouldn't have to change this flag.
 WARNERROR ?= yes
@@ -322,65 +326,65 @@ 
 SVNDEF := -D'FLASHROM_VERSION="$(VERSION)"'
 
 # Always enable internal/onboard support for now.
-CONFIG_INTERNAL ?= yes
+CONFIG_INTERNAL ?= $(CONFIG_DEFAULT)
 
 # Always enable serprog for now. Needs to be disabled on Windows.
-CONFIG_SERPROG ?= yes
+CONFIG_SERPROG ?= $(CONFIG_DEFAULT)
 
 # RayeR SPIPGM hardware support
-CONFIG_RAYER_SPI ?= yes
+CONFIG_RAYER_SPI ?= $(CONFIG_DEFAULT)
 
 # PonyProg2000 SPI hardware support
-CONFIG_PONY_SPI ?= yes
+CONFIG_PONY_SPI ?= $(CONFIG_DEFAULT)
 
 # Always enable 3Com NICs for now.
-CONFIG_NIC3COM ?= yes
+CONFIG_NIC3COM ?= $(CONFIG_DEFAULT)
 
 # Enable NVIDIA graphics cards. Note: write and erase do not work properly.
-CONFIG_GFXNVIDIA ?= yes
+CONFIG_GFXNVIDIA ?= $(CONFIG_DEFAULT)
 
 # Always enable SiI SATA controllers for now.
-CONFIG_SATASII ?= yes
+CONFIG_SATASII ?= $(CONFIG_DEFAULT)
 
 # Highpoint (HPT) ATA/RAID controller support.
 # IMPORTANT: This code is not yet working!
 CONFIG_ATAHPT ?= no
 
 # Always enable FT2232 SPI dongles for now.
-CONFIG_FT2232_SPI ?= yes
+CONFIG_FT2232_SPI ?= $(CONFIG_DEFAULT)
 
 # Always enable dummy tracing for now.
-CONFIG_DUMMY ?= yes
+CONFIG_DUMMY ?= $(CONFIG_DEFAULT)
 
 # Always enable Dr. Kaiser for now.
-CONFIG_DRKAISER ?= yes
+CONFIG_DRKAISER ?= $(CONFIG_DEFAULT)
 
 # Always enable Realtek NICs for now.
-CONFIG_NICREALTEK ?= yes
+CONFIG_NICREALTEK ?= $(CONFIG_DEFAULT)
 
 # Disable National Semiconductor NICs until support is complete and tested.
 CONFIG_NICNATSEMI ?= no
 
 # Always enable Intel NICs for now.
-CONFIG_NICINTEL ?= yes
+CONFIG_NICINTEL ?= $(CONFIG_DEFAULT)
 
 # Always enable SPI on Intel NICs for now.
-CONFIG_NICINTEL_SPI ?= yes
+CONFIG_NICINTEL_SPI ?= $(CONFIG_DEFAULT)
 
 # Always enable SPI on OGP cards for now.
-CONFIG_OGP_SPI ?= yes
+CONFIG_OGP_SPI ?= $(CONFIG_DEFAULT)
 
 # Always enable Bus Pirate SPI for now.
-CONFIG_BUSPIRATE_SPI ?= yes
+CONFIG_BUSPIRATE_SPI ?= $(CONFIG_DEFAULT)
 
 # Disable Dediprog SF100 until support is complete and tested.
 CONFIG_DEDIPROG ?= no
 
 # Always enable Marvell SATA controllers for now.
-CONFIG_SATAMV ?= yes
+CONFIG_SATAMV ?= $(CONFIG_DEFAULT)
 
 # Enable Linux spidev interface by default. We disable it on non-Linux targets.
-CONFIG_LINUX_SPI ?= yes
+CONFIG_LINUX_SPI ?= $(CONFIG_DEFAULT)
 
 # Disable wiki printing by default. It is only useful if you have wiki access.
 CONFIG_PRINT_WIKI ?= no