Patchwork enable NVIDIA MCP89 chipset

login
register
about
Submitter James Laird
Date 2013-03-20 05:24:22
Message ID <20130320052422.GA13900@unibuddy.mmn>
Download mbox | patch
Permalink /patch/3889/
State Accepted
Headers show

Comments

James Laird - 2013-03-20 05:24:22
Hello,

I have successfully read from an MCP89 chipset. Have not tested write (it's a laptop: macbookpro 7,1). Flash chip is an SST25VF032B (SPI).

MCP-init log fragment:
---------------------------- snip ---------------------------------------
Found chipset "NVIDIA MCP89" with PCI ID 10de:0d80. 
This chipset is marked as untested. If you are using an up-to-date version
of flashrom *and* were (not) able to successfully update your firmware with it,
then please email a report to flashrom@flashrom.org including a verbose (-V) log.
Thank you!
Enabling flash write... This chipset is not really supported yet. Guesswork...
ISA/LPC bridge reg 0x8a contents: 0x40, bit 6 is 1, bit 5 is 0
Flash bus type is SPI
SPI on this chipset is WIP. Please report any success or failure by mailing us the verbose output to flashrom@flashrom.org, thanks!
Found SMBus device 10de:0d79 at 00:03:2
MCP SPI BAR is at 0xd3400000
Mapping NVIDIA MCP6x SPI at 0xd3400000, unaligned size 0x544.
SPI control is 0xc145, req=1, gnt=1
Please send the output of "flashrom -V" to flashrom@flashrom.org with
your board name: flashrom -V as the subject to help us finish support for your
chipset. Thanks.
OK.
----------------------------- snip ---------------------------------------

Patch follows.

Cheerio,
James





Signed-Off-By: James Laird <jhl@mafipulation.org>
Stefan Tauner - 2013-03-20 10:50:39
On Wed, 20 Mar 2013 16:24:22 +1100
James Laird <jhl@mafipulation.org> wrote:

> Hello,
> 
> I have successfully read from an MCP89 chipset. Have not tested write (it's a laptop: macbookpro 7,1). Flash chip is an SST25VF032B (SPI).

Thank you James, I have added the line to my tested_stuff branch.

Patch

Index: chipset_enable.c
===================================================================
--- chipset_enable.c    (revision 1657)
+++ chipset_enable.c    (working copy)
@@ -1380,6 +1380,7 @@ 
    {0x10de, 0x0aad, NT, "NVIDIA", "MCP79",     enable_flash_mcp6x_7x},
    {0x10de, 0x0aae, NT, "NVIDIA", "MCP79",     enable_flash_mcp6x_7x},
    {0x10de, 0x0aaf, NT, "NVIDIA", "MCP79",     enable_flash_mcp6x_7x},
+   {0x10de, 0x0d80, NT, "NVIDIA", "MCP89",     enable_flash_mcp6x_7x},
    /* VIA northbridges */
    {0x1106, 0x0585, NT, "VIA", "VT82C585VPX",  via_no_byte_merge},
    {0x1106, 0x0595, NT, "VIA", "VT82C595",     via_no_byte_merge},