Abort on unused programmer parameters

Submitter	Carl-Daniel Hailfinger
Date	2013-08-12 23:25:17
Message ID	<52096EDD.1070004@gmx.net>
Download	mbox \| patch
Permalink	/patch/4023/
State	Accepted
Commit	r1708
Headers	show Return-path: <flashrom-bounces+patchwork=coreboot.org@flashrom.org> Envelope-to: patchwork@coreboot.org Message-ID: <52096EDD.1070004@gmx.net> Date: Tue, 13 Aug 2013 01:25:17 +0200 From: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> User-Agent: Mozilla/5.0 (X11; Linux i686; rv:20.0) Gecko/20100101 Firefox/20.0 SeaMonkey/2.17 MIME-Version: 1.0 To: flashrom@flashrom.org References: <52065F93.2030409@gmx.net> <201308112253.r7BMrtPA007754@mail2.student.tuwien.ac.at> In-Reply-To: <201308112253.r7BMrtPA007754@mail2.student.tuwien.ac.at> Subject: Re: [flashrom] [PATCH] Abort on unused programmer parameters Precedence: list Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: flashrom-bounces+patchwork=coreboot.org@flashrom.org Sender: flashrom-bounces+patchwork=coreboot.org@flashrom.org

Comments

Carl-Daniel Hailfinger - 2013-08-12 23:25:17

Am 12.08.2013 00:53 schrieb Stefan Tauner:
> On Sat, 10 Aug 2013 17:43:15 +0200
> Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> wrote:
>
>> An unused programmer parameter is a sign that the user wanted to either
>> do something not supported by the programmer or misspelled a parameter
>> which may be essential for the given programmer. Aborting is the only
>> safe choice.
>>
>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
>>
>> Index: flashrom-abort_unused_programmer_param/flashrom.c
>> ===================================================================
>> --- flashrom-abort_unused_programmer_param/flashrom.c	(Revision 1706)
>> +++ flashrom-abort_unused_programmer_param/flashrom.c	(Arbeitskopie)
>> @@ -389,13 +389,14 @@
>>  	programmer_may_write = 1;
>>  
>>  	programmer_param = param;
>> -	msg_pdbg("Initializing %s programmer\n",
>> -		 programmer_table[programmer].name);
>> +	msg_pdbg("Initializing %s programmer\n", programmer_table[programmer].name);
>>  	ret = programmer_table[programmer].init();
>>  	if (programmer_param && strlen(programmer_param)) {
>> -		msg_perr("Unhandled programmer parameters: %s\n",
>> -			 programmer_param);
>> -		/* Do not error out here, the init itself was successful. */
>> +		msg_perr("Unhandled programmer parameters: %s\n", programmer_param);
>> +		msg_perr("Aborting.\n");
> Considering pro and contra arguments for (not) combining these two
> lines, I am fine with it.</blah :)>
>
>> +		/* Do not overwrite any error code from programmer init. */
>> +		if (!ret)
>> +			ret = ERROR_FATAL;
>>  	}
>>  	return ret;
>>  }
>>
> IMHO the if is unnecessary, not beneficial and should be gone.
> In any case it is 
> Acked-by: Stefan Tauner <stefan.tauner@student.tuwien.ac.at>
> and I want that in 0.9.7.

Thanks!

After an extensive review on IRC, this will hopefully be a proper
implementation of the agreed upon programmer behaviour.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>

Stefan Tauner - 2013-08-13 02:30:02

On Tue, 13 Aug 2013 01:25:17 +0200
Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> wrote:

> Am 12.08.2013 00:53 schrieb Stefan Tauner:
>
> > IMHO the if is unnecessary, not beneficial and should be gone.
> > In any case it is 
> > Acked-by: Stefan Tauner <stefan.tauner@student.tuwien.ac.at>
> > and I want that in 0.9.7.
> 
> Thanks!
> 
> After an extensive review on IRC, this will hopefully be a proper
> implementation of the agreed upon programmer behaviour.
> 
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
> 
> Index: flashrom-abort_unused_programmer_param/flashrom.c
> ===================================================================
> --- flashrom-abort_unused_programmer_param/flashrom.c	(Revision 1706)
> +++ flashrom-abort_unused_programmer_param/flashrom.c	(Arbeitskopie)
> @@ -389,13 +389,23 @@
>  	programmer_may_write = 1;
>  
>  	programmer_param = param;
> -	msg_pdbg("Initializing %s programmer\n",
> -		 programmer_table[programmer].name);
> +	msg_pdbg("Initializing %s programmer\n", programmer_table[programmer].name);
>  	ret = programmer_table[programmer].init();
>  	if (programmer_param && strlen(programmer_param)) {
> -		msg_perr("Unhandled programmer parameters: %s\n",
> -			 programmer_param);
> -		/* Do not error out here, the init itself was successful. */
> +		if (ret != 0) {

I would have swapped the if/else branches, i.e. if (ret == 0) /* hard
error */ else /* possibly due to another failure */, but that's just my
weird taste probably :)

> +			/* It is quite possible that any unhandled programmer parameter would have been valid,
> +			 * but an error in actual programmer init happened before the parameter was evaluated.
> +			 */
> +			msg_pwarn("Unhandled programmer parameters (possibly due to another failure): %s\n",
> +				  programmer_param);
> +		} else {
> +			/* Actual programmer init was successful, but the user specified an invalid or unusable
> +			 * (for the current programmer configuration) parameter.
> +			 */
> +			msg_perr("Unhandled programmer parameters: %s\n", programmer_param);
> +			msg_perr("Aborting.\n");
> +			ret = ERROR_FATAL;
> +		}
>  	}
>  	return ret;

I can not imagine how this could possibly break anything in vanilla
flashrom. I have also tested it with the dummy programmer:

$ ./flashrom -p dummy:emulate=M25P10.RES,fail
flashrom v0.9.6.1-r1707 on Linux 3.8.0-6-generic (x86_64)
flashrom is free software, get the source code at http://www.flashrom.org

Calibrating delay loop... OK.
Unhandled programmer parameters: fail
Aborting.
Error: Programmer initialization failed.

$ ./flashrom -p dummy:emulate=initfail,image=persistent.img
flashrom v0.9.6.1-r1707 on Linux 3.8.0-6-generic (x86_64)
flashrom is free software, get the source code at http://www.flashrom.org

Calibrating delay loop... OK.
Invalid chip specified for emulation: initfail
Unhandled programmer parameters (possibly due to another failure): image=persistent.img
Error: Programmer initialization failed.

Hence...
Acked-by: Stefan Tauner <stefan.tauner@student.tuwien.ac.at>

Carl-Daniel Hailfinger - 2013-08-13 07:11:47

Am 13.08.2013 04:30 schrieb Stefan Tauner:
> On Tue, 13 Aug 2013 01:25:17 +0200
> Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> wrote:
>
>> --- flashrom-abort_unused_programmer_param/flashrom.c	(Revision 1706)
>> +++ flashrom-abort_unused_programmer_param/flashrom.c	(Arbeitskopie)
>> @@ -389,13 +389,23 @@
>>  	programmer_may_write = 1;
>>  
>>  	programmer_param = param;
>> -	msg_pdbg("Initializing %s programmer\n",
>> -		 programmer_table[programmer].name);
>> +	msg_pdbg("Initializing %s programmer\n", programmer_table[programmer].name);
>>  	ret = programmer_table[programmer].init();
>>  	if (programmer_param && strlen(programmer_param)) {
>> -		msg_perr("Unhandled programmer parameters: %s\n",
>> -			 programmer_param);
>> -		/* Do not error out here, the init itself was successful. */
>> +		if (ret != 0) {
> I would have swapped the if/else branches, i.e. if (ret == 0) /* hard
> error */ else /* possibly due to another failure */, but that's just my
> weird taste probably :)
> I can not imagine how this could possibly break anything in vanilla
> flashrom. I have also tested it with the dummy programmer:
>
> $ ./flashrom -p dummy:emulate=M25P10.RES,fail
> flashrom v0.9.6.1-r1707 on Linux 3.8.0-6-generic (x86_64)
> flashrom is free software, get the source code at http://www.flashrom.org
>
> Calibrating delay loop... OK.
> Unhandled programmer parameters: fail
> Aborting.
> Error: Programmer initialization failed.
>
> $ ./flashrom -p dummy:emulate=initfail,image=persistent.img
> flashrom v0.9.6.1-r1707 on Linux 3.8.0-6-generic (x86_64)
> flashrom is free software, get the source code at http://www.flashrom.org
>
> Calibrating delay loop... OK.
> Invalid chip specified for emulation: initfail
> Unhandled programmer parameters (possibly due to another failure): image=persistent.img
> Error: Programmer initialization failed.
>
> Hence...
> Acked-by: Stefan Tauner <stefan.tauner@student.tuwien.ac.at>

Thanks for the review and for testing!

Committed in r1708.

Regards,
Carl-Daniel

Patch

Index: flashrom-abort_unused_programmer_param/flashrom.c
===================================================================
--- flashrom-abort_unused_programmer_param/flashrom.c	(Revision 1706)
+++ flashrom-abort_unused_programmer_param/flashrom.c	(Arbeitskopie)
@@ -389,13 +389,23 @@ 
 	programmer_may_write = 1;
 
 	programmer_param = param;
-	msg_pdbg("Initializing %s programmer\n",
-		 programmer_table[programmer].name);
+	msg_pdbg("Initializing %s programmer\n", programmer_table[programmer].name);
 	ret = programmer_table[programmer].init();
 	if (programmer_param && strlen(programmer_param)) {
-		msg_perr("Unhandled programmer parameters: %s\n",
-			 programmer_param);
-		/* Do not error out here, the init itself was successful. */
+		if (ret != 0) {
+			/* It is quite possible that any unhandled programmer parameter would have been valid,
+			 * but an error in actual programmer init happened before the parameter was evaluated.
+			 */
+			msg_pwarn("Unhandled programmer parameters (possibly due to another failure): %s\n",
+				  programmer_param);
+		} else {
+			/* Actual programmer init was successful, but the user specified an invalid or unusable
+			 * (for the current programmer configuration) parameter.
+			 */
+			msg_perr("Unhandled programmer parameters: %s\n", programmer_param);
+			msg_perr("Aborting.\n");
+			ret = ERROR_FATAL;
+		}
 	}
 	return ret;
 }

Patchwork Abort on unused programmer parameters

Comments

Patch