Patchwork kconfig: Fix QEMU CPU Makefile.inc files

login
register
about
Submitter Uwe Hermann
Date 2009-10-16 00:24:31
Message ID <20091016002431.GN15511@greenwood>
Download mbox | patch
Permalink /patch/413/
State Accepted
Commit r4848
Headers show

Comments

Uwe Hermann - 2009-10-16 00:24:31
See patch.

This adapts the behavior to match that of the other CPUs, please correct
me if this is the wrong thing to do. It's build- and runtime-tested
on QEMU.


Uwe.
Uwe Hermann - 2009-10-23 22:57:46
On Fri, Oct 16, 2009 at 02:24:31AM +0200, Uwe Hermann wrote:
> This adapts the behavior to match that of the other CPUs, please correct
> me if this is the wrong thing to do. It's build- and runtime-tested
> on QEMU.

> Change QEMU CPU Makefile.inc files to match other CPUs.
> 
> Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
> 
> Index: src/cpu/emulation/Makefile.inc
> ===================================================================
> --- src/cpu/emulation/Makefile.inc	(Revision 4780)
> +++ src/cpu/emulation/Makefile.inc	(Arbeitskopie)
> @@ -1 +1 @@
> -subdirs-y += qemu-x86
> +subdirs-$(CONFIG_CPU_EMULATION_QEMU_X86) += qemu-x86
> Index: src/cpu/emulation/qemu-x86/Makefile.inc
> ===================================================================
> --- src/cpu/emulation/qemu-x86/Makefile.inc	(Revision 4780)
> +++ src/cpu/emulation/qemu-x86/Makefile.inc	(Arbeitskopie)
> @@ -1 +1 @@
> -obj-$(CONFIG_CPU_EMULATION_QEMU_X86) += northbridge.o
> +obj-y += northbridge.o

Ping?

Does this make sense? Is there a reason the QEMU target should look
different to the other ones?


Uwe.
Myles Watson - 2009-10-23 22:59:57
On Thu, Oct 15, 2009 at 6:24 PM, Uwe Hermann <uwe@hermann-uwe.de> wrote:

> See patch.
>
> This adapts the behavior to match that of the other CPUs, please correct
> me if this is the wrong thing to do. It's build- and runtime-tested
> on QEMU.
>
Acked-by: Myles Watson <mylesgw@gmail.com>

Thanks,
Myles
Uwe Hermann - 2009-10-24 19:07:53
On Fri, Oct 23, 2009 at 04:59:57PM -0600, Myles Watson wrote:
> > This adapts the behavior to match that of the other CPUs, please correct
> > me if this is the wrong thing to do. It's build- and runtime-tested
> > on QEMU.
> >
> Acked-by: Myles Watson <mylesgw@gmail.com>

Thanks, r4848.


Uwe.

Patch

Change QEMU CPU Makefile.inc files to match other CPUs.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>

Index: src/cpu/emulation/Makefile.inc
===================================================================
--- src/cpu/emulation/Makefile.inc	(Revision 4780)
+++ src/cpu/emulation/Makefile.inc	(Arbeitskopie)
@@ -1 +1 @@ 
-subdirs-y += qemu-x86
+subdirs-$(CONFIG_CPU_EMULATION_QEMU_X86) += qemu-x86
Index: src/cpu/emulation/qemu-x86/Makefile.inc
===================================================================
--- src/cpu/emulation/qemu-x86/Makefile.inc	(Revision 4780)
+++ src/cpu/emulation/qemu-x86/Makefile.inc	(Arbeitskopie)
@@ -1 +1 @@ 
-obj-$(CONFIG_CPU_EMULATION_QEMU_X86) += northbridge.o
+obj-y += northbridge.o