Patchwork Drop duplicate CPU subdirs-y entries for "../../x86/mtrr"

login
register
about
Submitter Uwe Hermann
Date 2009-10-16 00:51:20
Message ID <20091016005118.GO15511@greenwood>
Download mbox | patch
Permalink /patch/415/
State Accepted
Commit r4784
Headers show

Comments

Uwe Hermann - 2009-10-16 00:51:20
I see no reason why we'd want to include ../../x86/mtrr _twice_ in a
Makefile.inc, but if there are reasons for that we should definately
document them.


Uwe.
Peter Stuge - 2009-10-16 01:32:07
Uwe Hermann wrote:
>  subdirs-y += ../../x86/tsc
> -subdirs-y += ../../x86/mtrr
>  subdirs-y += ../../x86/fpu
>  subdirs-y += ../../x86/mmx
>  subdirs-y += ../../x86/sse

Could these last two be set in cpu/x86 by CONFIG_{MMX,SSE} ?


//Peter
Stefan Reinauer - 2009-10-16 02:29:19
Peter Stuge wrote:
> Uwe Hermann wrote:
>   
>>  subdirs-y += ../../x86/tsc
>> -subdirs-y += ../../x86/mtrr
>>  subdirs-y += ../../x86/fpu
>>  subdirs-y += ../../x86/mmx
>>  subdirs-y += ../../x86/sse
>>     
>
> Could these last two be set in cpu/x86 by CONFIG_{MMX,SSE} ?
>   

That, or dropped.. They're noops, really.
Peter Stuge - 2009-10-16 03:46:37
Uwe Hermann wrote:
> Drop duplicate CPU subdirs-y entries for "../../x86/mtrr".
> 
> Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>

Acked-by: Peter Stuge <peter@stuge.se>
Uwe Hermann - 2009-10-16 10:05:02
On Fri, Oct 16, 2009 at 05:46:37AM +0200, Peter Stuge wrote:
> Uwe Hermann wrote:
> > Drop duplicate CPU subdirs-y entries for "../../x86/mtrr".
> > 
> > Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
> 
> Acked-by: Peter Stuge <peter@stuge.se>

Thanks, r4784.


Uwe.

Patch

Drop duplicate CPU subdirs-y entries for "../../x86/mtrr".

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>

Index: src/cpu/amd/socket_940/Makefile.inc
===================================================================
--- src/cpu/amd/socket_940/Makefile.inc	(Revision 4781)
+++ src/cpu/amd/socket_940/Makefile.inc	(Arbeitskopie)
@@ -4,7 +4,6 @@ 
 subdirs-y += ../mtrr
 subdirs-y += ../microcode
 subdirs-y += ../../x86/tsc
-subdirs-y += ../../x86/mtrr
 subdirs-y += ../../x86/fpu
 subdirs-y += ../../x86/mmx
 subdirs-y += ../../x86/sse
Index: src/cpu/amd/socket_AM2/Makefile.inc
===================================================================
--- src/cpu/amd/socket_AM2/Makefile.inc	(Revision 4781)
+++ src/cpu/amd/socket_AM2/Makefile.inc	(Arbeitskopie)
@@ -4,7 +4,6 @@ 
 subdirs-y += ../mtrr
 subdirs-y += ../microcode
 subdirs-y += ../../x86/tsc
-subdirs-y += ../../x86/mtrr
 subdirs-y += ../../x86/fpu
 subdirs-y += ../../x86/mmx
 subdirs-y += ../../x86/sse
Index: src/cpu/amd/socket_754/Makefile.inc
===================================================================
--- src/cpu/amd/socket_754/Makefile.inc	(Revision 4781)
+++ src/cpu/amd/socket_754/Makefile.inc	(Arbeitskopie)
@@ -4,7 +4,6 @@ 
 subdirs-y += ../mtrr
 subdirs-y += ../microcode
 subdirs-y += ../../x86/tsc
-subdirs-y += ../../x86/mtrr
 subdirs-y += ../../x86/fpu
 subdirs-y += ../../x86/mmx
 subdirs-y += ../../x86/sse
Index: src/cpu/amd/socket_939/Makefile.inc
===================================================================
--- src/cpu/amd/socket_939/Makefile.inc	(Revision 4781)
+++ src/cpu/amd/socket_939/Makefile.inc	(Arbeitskopie)
@@ -4,7 +4,6 @@ 
 subdirs-y += ../mtrr
 subdirs-y += ../microcode
 subdirs-y += ../../x86/tsc
-subdirs-y += ../../x86/mtrr
 subdirs-y += ../../x86/fpu
 subdirs-y += ../../x86/mmx
 subdirs-y += ../../x86/sse
Index: src/cpu/amd/socket_F/Makefile.inc
===================================================================
--- src/cpu/amd/socket_F/Makefile.inc	(Revision 4781)
+++ src/cpu/amd/socket_F/Makefile.inc	(Arbeitskopie)
@@ -4,7 +4,6 @@ 
 subdirs-y += ../mtrr
 subdirs-y += ../microcode
 subdirs-y += ../../x86/tsc
-subdirs-y += ../../x86/mtrr
 subdirs-y += ../../x86/fpu
 subdirs-y += ../../x86/mmx
 subdirs-y += ../../x86/sse
Index: src/cpu/amd/socket_F_1207/Makefile.inc
===================================================================
--- src/cpu/amd/socket_F_1207/Makefile.inc	(Revision 4781)
+++ src/cpu/amd/socket_F_1207/Makefile.inc	(Arbeitskopie)
@@ -4,7 +4,6 @@ 
 subdirs-y += ../mtrr
 subdirs-y += ../microcode
 subdirs-y += ../../x86/tsc
-subdirs-y += ../../x86/mtrr
 subdirs-y += ../../x86/fpu
 subdirs-y += ../../x86/mmx
 subdirs-y += ../../x86/sse