Patchwork Drop cpu/x86/{mmx,sse}/Makefile.inc

login
register
about
Submitter Peter Stuge
Date 2009-10-16 03:43:46
Message ID <20091016034346.1129.qmail@stuge.se>
Download mbox | patch
Permalink /patch/417/
State Accepted
Headers show

Comments

Peter Stuge - 2009-10-16 03:43:46
Stefan Reinauer wrote:
> >>  subdirs-y += ../../x86/mmx
> >>  subdirs-y += ../../x86/sse
> >
> > Could these last two be set in cpu/x86 by CONFIG_{MMX,SSE} ?
> 
> That, or dropped.. They're noops, really.

Said and done. Patch attached.


//Peter
Drop empty cpu/x86/{mmx,sse}/Makefile.inc

Signed-off-by: Peter Stuge <peter@stuge.se>
Uwe Hermann - 2009-10-16 16:03:47
On Fri, Oct 16, 2009 at 05:43:46AM +0200, Peter Stuge wrote:
> Drop empty cpu/x86/{mmx,sse}/Makefile.inc
> 
> Signed-off-by: Peter Stuge <peter@stuge.se>

Acked-by: Uwe Hermann <uwe@hermann-uwe.de>

Please also drop the empty Config.lb and Makefile.inc files (after
checking that abuild won't break).


Uwe.
ron minnich - 2009-10-16 16:12:04
[rminnich@amd64 coreboot-v2]$ ls src/cpu/x86/mmx/
Config.lb  disable_mmx.inc  enable_mmx.inc  Makefile.inc
[rminnich@amd64 coreboot-v2]$ ls src/cpu/x86/sse
Config.lb  disable_sse.inc  enable_sse.inc  Makefile.inc
[rminnich@amd64 coreboot-v2]$


great to get rid of the unnecessary Config.lb/Makefile.inc files. But
we'll still have two directories to hold 3 files!

And the name is mmx/disable_mmx.c? We repeat mmx twice. Could we just
remove the directories and put the files in src/cpu/x86/?

In fact why not just remove all the subdirs? I just looked and there
are many dirs with one source file, or two. And the files in many
cases have the directory name in them anyway ... These many
directories are confusing and overkill, really.

ron
Peter Stuge - 2009-10-16 16:16:29
ron minnich wrote:
> remove the directories and put the files in src/cpu/x86/?

I started doing that already, but wanted to start with the simplest
patches. :)


> In fact why not just remove all the subdirs? I just looked and
> there are many dirs with one source file, or two. And the files in
> many cases have the directory name in them anyway ... These many
> directories are confusing and overkill, really.

Agree completely.


//Peter
Peter Stuge - 2009-10-16 18:27:41
Uwe Hermann wrote:
> > Drop empty cpu/x86/{mmx,sse}/Makefile.inc
> 
> Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
> 
> Please also drop the empty Config.lb and Makefile.inc files (after
> checking that abuild won't break).

It was abuild tested. r4792

Patch

Index: src/cpu/via/model_c3/Makefile.inc
===================================================================
--- src/cpu/via/model_c3/Makefile.inc	(revision 4782)
+++ src/cpu/via/model_c3/Makefile.inc	(working copy)
@@ -1,8 +1,6 @@ 
 subdirs-y += ../../x86/tsc
 subdirs-y += ../../x86/mtrr
 subdirs-y += ../../x86/fpu
-subdirs-y += ../../x86/mmx
-subdirs-y += ../../x86/sse
 subdirs-y += ../../x86/lapic
 subdirs-y += ../../x86/cache
 subdirs-y += ../../x86/smm
Index: src/cpu/via/model_c7/Makefile.inc
===================================================================
--- src/cpu/via/model_c7/Makefile.inc	(revision 4782)
+++ src/cpu/via/model_c7/Makefile.inc	(working copy)
@@ -1,8 +1,6 @@ 
 subdirs-y += ../../x86/tsc
 subdirs-y += ../../x86/mtrr
 subdirs-y += ../../x86/fpu
-subdirs-y += ../../x86/mmx
-subdirs-y += ../../x86/sse
 subdirs-y += ../../x86/lapic
 subdirs-y += ../../x86/cache
 subdirs-y += ../../x86/smm
Index: src/cpu/amd/model_gx1/Makefile.inc
===================================================================
--- src/cpu/amd/model_gx1/Makefile.inc	(revision 4782)
+++ src/cpu/amd/model_gx1/Makefile.inc	(working copy)
@@ -20,7 +20,6 @@ 
 
 subdirs-y += ../../x86/tsc
 subdirs-y += ../../x86/fpu
-subdirs-y += ../../x86/mmx
 subdirs-y += ../../x86/lapic
 subdirs-y += ../../x86/cache
 subdirs-y += ../../x86/smm
Index: src/cpu/amd/model_gx2/Makefile.inc
===================================================================
--- src/cpu/amd/model_gx2/Makefile.inc	(revision 4782)
+++ src/cpu/amd/model_gx2/Makefile.inc	(working copy)
@@ -1,6 +1,5 @@ 
 subdirs-y += ../../x86/tsc
 subdirs-y += ../../x86/fpu
-subdirs-y += ../../x86/mmx
 subdirs-y += ../../x86/lapic
 subdirs-y += ../../x86/cache
 subdirs-y += ../../x86/smm
Index: src/cpu/amd/socket_S1G1/Makefile.inc
===================================================================
--- src/cpu/amd/socket_S1G1/Makefile.inc	(revision 4782)
+++ src/cpu/amd/socket_S1G1/Makefile.inc	(working copy)
@@ -5,8 +5,6 @@ 
 subdirs-y += ../microcode
 subdirs-y += ../../x86/tsc
 subdirs-y += ../../x86/fpu
-subdirs-y += ../../x86/mmx
-subdirs-y += ../../x86/sse
 subdirs-y += ../../x86/lapic
 subdirs-y += ../../x86/cache
 subdirs-y += ../../x86/pae
Index: src/cpu/amd/socket_940/Makefile.inc
===================================================================
--- src/cpu/amd/socket_940/Makefile.inc	(revision 4782)
+++ src/cpu/amd/socket_940/Makefile.inc	(working copy)
@@ -6,8 +6,6 @@ 
 subdirs-y += ../../x86/tsc
 subdirs-y += ../../x86/mtrr
 subdirs-y += ../../x86/fpu
-subdirs-y += ../../x86/mmx
-subdirs-y += ../../x86/sse
 subdirs-y += ../../x86/lapic
 subdirs-y += ../../x86/cache
 subdirs-y += ../../x86/mtrr
Index: src/cpu/amd/socket_AM2/Makefile.inc
===================================================================
--- src/cpu/amd/socket_AM2/Makefile.inc	(revision 4782)
+++ src/cpu/amd/socket_AM2/Makefile.inc	(working copy)
@@ -6,8 +6,6 @@ 
 subdirs-y += ../../x86/tsc
 subdirs-y += ../../x86/mtrr
 subdirs-y += ../../x86/fpu
-subdirs-y += ../../x86/mmx
-subdirs-y += ../../x86/sse
 subdirs-y += ../../x86/lapic
 subdirs-y += ../../x86/cache
 subdirs-y += ../../x86/mtrr
Index: src/cpu/amd/socket_754/Makefile.inc
===================================================================
--- src/cpu/amd/socket_754/Makefile.inc	(revision 4782)
+++ src/cpu/amd/socket_754/Makefile.inc	(working copy)
@@ -6,8 +6,6 @@ 
 subdirs-y += ../../x86/tsc
 subdirs-y += ../../x86/mtrr
 subdirs-y += ../../x86/fpu
-subdirs-y += ../../x86/mmx
-subdirs-y += ../../x86/sse
 subdirs-y += ../../x86/lapic
 subdirs-y += ../../x86/cache
 subdirs-y += ../../x86/mtrr
Index: src/cpu/amd/socket_AM2r2/Makefile.inc
===================================================================
--- src/cpu/amd/socket_AM2r2/Makefile.inc	(revision 4782)
+++ src/cpu/amd/socket_AM2r2/Makefile.inc	(working copy)
@@ -5,8 +5,6 @@ 
 subdirs-y += ../microcode
 subdirs-y += ../../x86/tsc
 subdirs-y += ../../x86/fpu
-subdirs-y += ../../x86/mmx
-subdirs-y += ../../x86/sse
 subdirs-y += ../../x86/lapic
 subdirs-y += ../../x86/cache
 subdirs-y += ../../x86/pae
Index: src/cpu/amd/socket_939/Makefile.inc
===================================================================
--- src/cpu/amd/socket_939/Makefile.inc	(revision 4782)
+++ src/cpu/amd/socket_939/Makefile.inc	(working copy)
@@ -6,8 +6,6 @@ 
 subdirs-y += ../../x86/tsc
 subdirs-y += ../../x86/mtrr
 subdirs-y += ../../x86/fpu
-subdirs-y += ../../x86/mmx
-subdirs-y += ../../x86/sse
 subdirs-y += ../../x86/lapic
 subdirs-y += ../../x86/cache
 subdirs-y += ../../x86/mtrr
Index: src/cpu/amd/socket_F/Makefile.inc
===================================================================
--- src/cpu/amd/socket_F/Makefile.inc	(revision 4782)
+++ src/cpu/amd/socket_F/Makefile.inc	(working copy)
@@ -6,8 +6,6 @@ 
 subdirs-y += ../../x86/tsc
 subdirs-y += ../../x86/mtrr
 subdirs-y += ../../x86/fpu
-subdirs-y += ../../x86/mmx
-subdirs-y += ../../x86/sse
 subdirs-y += ../../x86/lapic
 subdirs-y += ../../x86/cache
 subdirs-y += ../../x86/mtrr
Index: src/cpu/amd/model_lx/Makefile.inc
===================================================================
--- src/cpu/amd/model_lx/Makefile.inc	(revision 4782)
+++ src/cpu/amd/model_lx/Makefile.inc	(working copy)
@@ -1,6 +1,5 @@ 
 subdirs-y += ../../x86/tsc
 subdirs-y += ../../x86/fpu
-subdirs-y += ../../x86/mmx
 subdirs-y += ../../x86/lapic
 subdirs-y += ../../x86/cache
 subdirs-y += ../../x86/smm
Index: src/cpu/amd/socket_F_1207/Makefile.inc
===================================================================
--- src/cpu/amd/socket_F_1207/Makefile.inc	(revision 4782)
+++ src/cpu/amd/socket_F_1207/Makefile.inc	(working copy)
@@ -6,8 +6,6 @@ 
 subdirs-y += ../../x86/tsc
 subdirs-y += ../../x86/mtrr
 subdirs-y += ../../x86/fpu
-subdirs-y += ../../x86/mmx
-subdirs-y += ../../x86/sse
 subdirs-y += ../../x86/lapic
 subdirs-y += ../../x86/cache
 subdirs-y += ../../x86/mtrr
Index: src/cpu/intel/ep80579/Makefile.inc
===================================================================
--- src/cpu/intel/ep80579/Makefile.inc	(revision 4782)
+++ src/cpu/intel/ep80579/Makefile.inc	(working copy)
@@ -3,8 +3,6 @@ 
 subdirs-y += ../../x86/tsc
 subdirs-y += ../../x86/mtrr
 subdirs-y += ../../x86/fpu
-subdirs-y += ../../x86/mmx
-subdirs-y += ../../x86/sse
 subdirs-y += ../../x86/lapic
 subdirs-y += ../../x86/cache
 subdirs-y += ../../x86/smm
Index: src/cpu/intel/socket_mPGA603/Makefile.inc
===================================================================
--- src/cpu/intel/socket_mPGA603/Makefile.inc	(revision 4782)
+++ src/cpu/intel/socket_mPGA603/Makefile.inc	(working copy)
@@ -5,8 +5,6 @@ 
 subdirs-y += ../../x86/tsc
 subdirs-y += ../../x86/mtrr
 subdirs-y += ../../x86/fpu
-subdirs-y += ../../x86/mmx
-subdirs-y += ../../x86/sse
 subdirs-y += ../../x86/lapic
 subdirs-y += ../../x86/cache
 subdirs-y += ../../x86/smm
Index: src/cpu/intel/socket_mPGA604/Makefile.inc
===================================================================
--- src/cpu/intel/socket_mPGA604/Makefile.inc	(revision 4782)
+++ src/cpu/intel/socket_mPGA604/Makefile.inc	(working copy)
@@ -5,8 +5,6 @@ 
 subdirs-y += ../../x86/tsc
 subdirs-y += ../../x86/mtrr
 subdirs-y += ../../x86/fpu
-subdirs-y += ../../x86/mmx
-subdirs-y += ../../x86/sse
 subdirs-y += ../../x86/lapic
 subdirs-y += ../../x86/cache
 subdirs-y += ../../x86/smm
Index: src/cpu/intel/bga956/Makefile.inc
===================================================================
--- src/cpu/intel/bga956/Makefile.inc	(revision 4782)
+++ src/cpu/intel/bga956/Makefile.inc	(working copy)
@@ -3,8 +3,6 @@ 
 subdirs-y += ../../x86/tsc
 subdirs-y += ../../x86/mtrr
 subdirs-y += ../../x86/fpu
-subdirs-y += ../../x86/mmx
-subdirs-y += ../../x86/sse
 subdirs-y += ../../x86/lapic
 subdirs-y += ../../x86/cache
 subdirs-y += ../../x86/smm
Index: src/cpu/intel/socket_mPGA478/Makefile.inc
===================================================================
--- src/cpu/intel/socket_mPGA478/Makefile.inc	(revision 4782)
+++ src/cpu/intel/socket_mPGA478/Makefile.inc	(working copy)
@@ -4,8 +4,6 @@ 
 subdirs-y += ../../x86/tsc
 subdirs-y += ../../x86/mtrr
 subdirs-y += ../../x86/fpu
-subdirs-y += ../../x86/mmx
-subdirs-y += ../../x86/sse
 subdirs-y += ../../x86/lapic
 subdirs-y += ../../x86/cache
 subdirs-y += ../../x86/smm
Index: src/cpu/intel/slot_2/Makefile.inc
===================================================================
--- src/cpu/intel/slot_2/Makefile.inc	(revision 4782)
+++ src/cpu/intel/slot_2/Makefile.inc	(working copy)
@@ -23,8 +23,6 @@ 
 subdirs-y += ../../x86/tsc
 subdirs-y += ../../x86/mtrr
 subdirs-y += ../../x86/fpu
-subdirs-y += ../../x86/mmx
-subdirs-y += ../../x86/sse
 subdirs-y += ../../x86/lapic
 subdirs-y += ../../x86/cache
 subdirs-y += ../../x86/smm
Index: src/cpu/intel/socket_mFCPGA478/Makefile.inc
===================================================================
--- src/cpu/intel/socket_mFCPGA478/Makefile.inc	(revision 4782)
+++ src/cpu/intel/socket_mFCPGA478/Makefile.inc	(working copy)
@@ -6,8 +6,6 @@ 
 subdirs-y += ../../x86/tsc
 subdirs-y += ../../x86/mtrr
 subdirs-y += ../../x86/fpu
-subdirs-y += ../../x86/mmx
-subdirs-y += ../../x86/sse
 subdirs-y += ../../x86/lapic
 subdirs-y += ../../x86/cache
 subdirs-y += ../../x86/smm
Index: src/cpu/intel/socket_PGA370/Makefile.inc
===================================================================
--- src/cpu/intel/socket_PGA370/Makefile.inc	(revision 4782)
+++ src/cpu/intel/socket_PGA370/Makefile.inc	(working copy)
@@ -23,8 +23,6 @@ 
 subdirs-y += ../../x86/tsc
 subdirs-y += ../../x86/mtrr
 subdirs-y += ../../x86/fpu
-subdirs-y += ../../x86/mmx
-subdirs-y += ../../x86/sse
 subdirs-y += ../../x86/lapic
 subdirs-y += ../../x86/cache
 subdirs-y += ../../x86/smm
Index: src/cpu/intel/socket_mPGA479M/Makefile.inc
===================================================================
--- src/cpu/intel/socket_mPGA479M/Makefile.inc	(revision 4782)
+++ src/cpu/intel/socket_mPGA479M/Makefile.inc	(working copy)
@@ -4,8 +4,6 @@ 
 subdirs-y += ../../x86/tsc
 subdirs-y += ../../x86/mtrr
 subdirs-y += ../../x86/fpu
-subdirs-y += ../../x86/mmx
-subdirs-y += ../../x86/sse
 subdirs-y += ../../x86/lapic
 subdirs-y += ../../x86/cache
 subdirs-y += ../../x86/smm