Patchwork Add support for Micronix MX29F022(N)T

login
register
about
Submitter Daniele Forsi
Date 2014-07-04 21:30:39
Message ID <CAN_we7OMGi5q_PLQAa9zfFYbSeqmWDgD_dr8JTPa-cm8fDMX1g@mail.gmail.com>
Download mbox | patch
Permalink /patch/4205/
State Superseded
Headers show

Comments

Daniele Forsi - 2014-07-04 21:30:39
Hello,
I successfully tested the following patch with read, erase and write
but I don't know how do I choose a value for .page_size?

Signed-off-by: Daniele Forsi <dforsi@gmail.com>
Stefan Tauner - 2014-07-10 11:30:24
On Fri, 4 Jul 2014 23:30:39 +0200
Daniele Forsi <dforsi@gmail.com> wrote:

> Hello,

Hello Daniele,

thanks for your patch!

> I successfully tested the following patch with read, erase and write
> but I don't know how do I choose a value for .page_size?

you don't if you dont have to, and i think it is not necessary in your
case. that field will be removed in the future.
i suggest that you use ".page_size	= 0, /* unused */"

There is only one major problem with your patch: it got mangled before
sending (probably by your MUA). Can you please resend it properly?

Patch

Index: flashchips.c
===================================================================
--- flashchips.c (revision 1822)
+++ flashchips.c (working copy)
@@ -6996,6 +6996,38 @@ 

  {
  .vendor = "Macronix",
+ .name = "MX29F022(N)T",
+ .bustype = BUS_PARALLEL,
+ .manufacture_id = MACRONIX_ID,
+ .model_id = MACRONIX_MX29F022T,
+ .total_size = 256,
+ .page_size = 32 * 1024,
+ .feature_bits = FEATURE_ADDR_2AA | FEATURE_SHORT_RESET,
+ .tested = TEST_OK_PREW,
+ .probe = probe_jedec,
+ .probe_timing = TIMING_ZERO,
+ .block_erasers =
+ {
+ {
+ .eraseblocks = {
+ {64 * 1024, 3},
+ {32 * 1024, 1},
+ {8 * 1024, 2},
+ {16 * 1024, 1},
+ },
+ .block_erase = erase_sector_jedec,
+ }, {
+ .eraseblocks = { {256 * 1024, 1} },
+ .block_erase = erase_chip_block_jedec,
+ }
+ },
+ .write = write_jedec_1,
+ .read = read_memmapped,
+ .voltage = {4500, 5500},
+ },
+
+ {
+ .vendor = "Macronix",
  .name = "MX29F040",
  .bustype = BUS_PARALLEL,
  .manufacture_id = MACRONIX_ID,