| Submitter | Uwe Hermann |
|---|---|
| Date | 2009-10-16 14:04:20 |
| Message ID | <20091016140420.GU15511@greenwood> |
| Download | mbox | patch |
| Permalink | /patch/421/ |
| State | Superseded |
| Headers | show |
Comments
> Subject: [coreboot] [PATCH] kconfig: Set MAX_PCI_BUSES to same values as
Can we just remove it from newconfig and Kconfig? It's never used in the
code.
Thanks,
Myles
Uwe Hermann wrote: > kconfig: Set MAX_PCI_BUSES to same values as in oldconfig. > > Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de> Acked-by: Peter Stuge <peter@stuge.se>
Myles Watson wrote: > > Subject: [coreboot] [PATCH] kconfig: Set MAX_PCI_BUSES to same values as > > Can we just remove it from newconfig and Kconfig? It's never used in > the code. Or fix the code? Shouldn't it be used? //Peter
On Fri, Oct 16, 2009 at 8:29 AM, Peter Stuge <peter@stuge.se> wrote: > Myles Watson wrote: > > > Subject: [coreboot] [PATCH] kconfig: Set MAX_PCI_BUSES to same values > as > > > > Can we just remove it from newconfig and Kconfig? It's never used in > > the code. > > Or fix the code? Shouldn't it be used? > For what? Thanks, Myles
Myles Watson wrote: > > > > Subject: [coreboot] [PATCH] kconfig: Set MAX_PCI_BUSES to same > > > > values as > > > > > > Can we just remove it from newconfig and Kconfig? It's never > > > used in the code. > > > > Or fix the code? Shouldn't it be used? > > For what? Stop scanning PCI busses? //Peter
On Fri, Oct 16, 2009 at 8:39 AM, Peter Stuge <peter@stuge.se> wrote: > Myles Watson wrote: > > > > > Subject: [coreboot] [PATCH] kconfig: Set MAX_PCI_BUSES to same > > > > > values as > > > > > > > > Can we just remove it from newconfig and Kconfig? It's never > > > > used in the code. > > > > > > Or fix the code? Shouldn't it be used? > > > > For what? > > Stop scanning PCI busses? > Right now the code scans the root bus and any bus it can find from there. It just scans until it finds no more devices which have a bus. I don't think we want to change the code to blindly scan from 0->MAX_PCI_BUSES. On my Tyan s2895 Board there are 6 PCI buses as it's configured: 0,1,2,40,41,42,80. You can plug in a card that will make more somewhere, but 3-39,43-79,81-... don't need to be scanned. Thanks, Myles
This variable may date way back to v1 and a problem I had with a via part, wherein scanning above a certain PCI bus would hang the chip up. I doubt we need it any more. ron
Patch
kconfig: Set MAX_PCI_BUSES to same values as in oldconfig. Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de> Index: src/Kconfig =================================================================== --- src/Kconfig (Revision 4786) +++ src/Kconfig (Arbeitskopie) @@ -150,6 +150,15 @@ bool default n +# TODO: Also set the global default to some smaller value? +config MAX_PCI_BUSES + int + default 255 + help + The maximum PCI bus number to be used for PCI config I/O. + Setting this number very high will make pci_locate_device() take + a long time when it can't find a device. + source src/console/Kconfig config HAVE_ACPI_RESUME Index: src/mainboard/bcom/winnetp680/Kconfig =================================================================== --- src/mainboard/bcom/winnetp680/Kconfig (Revision 4786) +++ src/mainboard/bcom/winnetp680/Kconfig (Arbeitskopie) @@ -34,3 +34,8 @@ default 0x4000 depends on BOARD_BCOM_WINNETP680 +config MAX_PCI_BUSES + int + default 3 + depends on BOARD_BCOM_WINNETP680 + Index: src/mainboard/via/epia-m700/Kconfig =================================================================== --- src/mainboard/via/epia-m700/Kconfig (Revision 4786) +++ src/mainboard/via/epia-m700/Kconfig (Arbeitskopie) @@ -40,3 +40,9 @@ int default 13 depends on BOARD_VIA_EPIA_M700 + +config MAX_PCI_BUSES + int + default 3 + depends on BOARD_VIA_EPIA_M700 + Index: src/mainboard/via/vt8454c/Kconfig =================================================================== --- src/mainboard/via/vt8454c/Kconfig (Revision 4786) +++ src/mainboard/via/vt8454c/Kconfig (Arbeitskopie) @@ -40,3 +40,9 @@ hex default 0x4000 depends on BOARD_VIA_VT8454C + +config MAX_PCI_BUSES + int + default 128 + depends on BOARD_VIA_VT8454C + Index: src/mainboard/via/epia-m/Kconfig =================================================================== --- src/mainboard/via/epia-m/Kconfig (Revision 4786) +++ src/mainboard/via/epia-m/Kconfig (Arbeitskopie) @@ -50,3 +50,8 @@ default n depends on BOARD_VIA_EPIA_M +config MAX_PCI_BUSES + int + default 5 + depends on BOARD_VIA_EPIA_M + Index: src/mainboard/via/epia-n/Kconfig =================================================================== --- src/mainboard/via/epia-n/Kconfig (Revision 4786) +++ src/mainboard/via/epia-n/Kconfig (Arbeitskopie) @@ -45,3 +45,8 @@ default 7 depends on BOARD_VIA_EPIA_N +config MAX_PCI_BUSES + int + default 3 + depends on BOARD_VIA_EPIA_N + Index: src/mainboard/via/epia-cn/Kconfig =================================================================== --- src/mainboard/via/epia-cn/Kconfig (Revision 4786) +++ src/mainboard/via/epia-cn/Kconfig (Arbeitskopie) @@ -41,3 +41,9 @@ int default 9 depends on BOARD_VIA_EPIA_CN + +config MAX_PCI_BUSES + int + default 3 + depends on BOARD_VIA_EPIA_CN + Index: src/mainboard/via/pc2500e/Kconfig =================================================================== --- src/mainboard/via/pc2500e/Kconfig (Revision 4786) +++ src/mainboard/via/pc2500e/Kconfig (Arbeitskopie) @@ -46,3 +46,8 @@ default 0xaa51 depends on BOARD_VIA_PC2500E +config MAX_PCI_BUSES + int + default 3 + depends on BOARD_VIA_PC2500E + Index: src/mainboard/jetway/j7f24/Kconfig =================================================================== --- src/mainboard/jetway/j7f24/Kconfig (Revision 4786) +++ src/mainboard/jetway/j7f24/Kconfig (Arbeitskopie) @@ -41,3 +41,9 @@ int default 10 depends on BOARD_JETWAY_J7F24 + +config MAX_PCI_BUSES + int + default 3 + depends on BOARD_JETWAY_J7F24 +