Patchwork Added support for Macronix MX23L1654, MX23L6454, and MX23L12854

login
register
about
Submitter Michael Coppola
Date 2014-08-16 23:11:46
Message ID <53EFE532.3000703@gmail.com>
Download mbox | patch
Permalink /patch/4234/
State Accepted
Headers show

Comments

Michael Coppola - 2014-08-16 23:11:46
Hi,

I've added support for the Macronix MX23L1654, MX23L6454, and MX23L12854
SPI mask ROM chips.  I do not physically have these chips and have not
tested, but I used the template for the MX23L3254 which I have
previously verified to work with a real chip.

Datasheets:
http://www.mxic.com.tw/Lists/DataSheet/Attachments/1216/MX23L1654,%203.0-3.3V,%2016Mb,%20v1.5.pdf
http://www.mxic.com.tw/Lists/DataSheet/Attachments/1234/MX23L6454,%203.0-3.3V,%2064Mb,%20v1.8.pdf
http://www.mxic.com.tw/Lists/DataSheet/Attachments/1232/MX23L12854,%203.0-3.3V,%20128Mb,%20v1.7.pdf

Signed-off-by: Michael Coppola <michael.n.coppola@gmail.com>
Stefan Tauner - 2014-08-20 18:58:23
On Sat, 16 Aug 2014 19:11:46 -0400
Michael Coppola <michael.n.coppola@gmail.com> wrote:

> Hi,
> 
> I've added support for the Macronix MX23L1654, MX23L6454, and MX23L12854
> SPI mask ROM chips.  I do not physically have these chips and have not
> tested, but I used the template for the MX23L3254 which I have
> previously verified to work with a real chip.

Then you should not have marked them as probe- and read-tested. ;)
I have changed that locally...

> Signed-off-by: Michael Coppola <michael.n.coppola@gmail.com>
Acked-by: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
and committed in r1846.
Thank you very much for your contribution!

Patch

Index: flashchips.c
===================================================================
--- flashchips.c	(revision 1842)
+++ flashchips.c	(working copy)
@@ -6322,6 +6322,22 @@ 
 
 	{
 		.vendor		= "Macronix",
+		.name		= "MX23L1654",
+		.bustype	= BUS_SPI,
+		.manufacture_id	= MACRONIX_ID,
+		.model_id	= MACRONIX_MX23L1654,
+		.total_size	= 2048,
+		.page_size	= 256,
+		.tested		= {.probe = OK, .read = OK, .erase = NA, .write = NA},
+		.probe		= probe_spi_rdid,
+		.probe_timing	= TIMING_ZERO,
+		.write		= NULL, /* MX23L1654 is a mask ROM, so it is read-only */
+		.read		= spi_chip_read, /* Fast read (0x0B) supported */
+		.voltage	= {3000, 3600},
+	},
+
+	{
+		.vendor		= "Macronix",
 		.name		= "MX23L3254",
 		.bustype	= BUS_SPI,
 		.manufacture_id	= MACRONIX_ID,
@@ -6338,6 +6354,38 @@ 
 
 	{
 		.vendor		= "Macronix",
+		.name		= "MX23L6454",
+		.bustype	= BUS_SPI,
+		.manufacture_id	= MACRONIX_ID,
+		.model_id	= MACRONIX_MX23L6454,
+		.total_size	= 8192,
+		.page_size	= 256,
+		.tested		= {.probe = OK, .read = OK, .erase = NA, .write = NA},
+		.probe		= probe_spi_rdid,
+		.probe_timing	= TIMING_ZERO,
+		.write		= NULL, /* MX23L6454 is a mask ROM, so it is read-only */
+		.read		= spi_chip_read, /* Fast read (0x0B) supported */
+		.voltage	= {3000, 3600},
+	},
+
+	{
+		.vendor		= "Macronix",
+		.name		= "MX23L12854",
+		.bustype	= BUS_SPI,
+		.manufacture_id	= MACRONIX_ID,
+		.model_id	= MACRONIX_MX23L12854,
+		.total_size	= 16384,
+		.page_size	= 256,
+		.tested		= {.probe = OK, .read = OK, .erase = NA, .write = NA},
+		.probe		= probe_spi_rdid,
+		.probe_timing	= TIMING_ZERO,
+		.write		= NULL, /* MX23L12854 is a mask ROM, so it is read-only */
+		.read		= spi_chip_read, /* Fast read (0x0B) supported */
+		.voltage	= {3000, 3600},
+	},
+
+	{
+		.vendor		= "Macronix",
 		.name		= "MX25L512(E)/MX25V512(C)",
 		.bustype	= BUS_SPI,
 		.manufacture_id	= MACRONIX_ID,
Index: flashchips.h
===================================================================
--- flashchips.h	(revision 1842)
+++ flashchips.h	(working copy)
@@ -448,7 +448,10 @@ 
 
 #define MACRONIX_ID		0xC2	/* Macronix (MX) */
 /* Mask ROMs */
+#define MACRONIX_MX23L1654	0x0515
 #define MACRONIX_MX23L3254	0x0516
+#define MACRONIX_MX23L6454	0x0517
+#define MACRONIX_MX23L12854	0x0518
 /* MX25 chips are SPI, first byte of device ID is memory type,
  * second byte of device ID is log(bitsize)-9.
  * Generalplus SPI chips seem to be compatible with Macronix