Patchwork Drop duplicate failover.c implementation

login
register
about
Submitter Uwe Hermann
Date 2009-10-18 13:40:32
Message ID <20091018134032.GE22827@greenwood>
Download mbox | patch
Permalink /patch/434/
State Accepted
Headers show

Comments

Uwe Hermann - 2009-10-18 13:40:32
See patch.


Uwe.
ron minnich - 2009-10-18 16:57:44
Acked-by: Ronald G. Minnich <rminnich@gmail.com>
Uwe Hermann - 2009-10-18 18:28:00
On Sun, Oct 18, 2009 at 09:57:44AM -0700, ron minnich wrote:
> Acked-by: Ronald G. Minnich <rminnich@gmail.com>

Thanks, r4807.


Uwe.

Patch

Drop a duplicated implementation of failover.c.

Abuild-tested.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>

Index: src/mainboard/iei/nova4899r/Config.lb
===================================================================
--- src/mainboard/iei/nova4899r/Config.lb	(Revision 4803)
+++ src/mainboard/iei/nova4899r/Config.lb	(Arbeitskopie)
@@ -22,13 +22,13 @@ 
 ## Romcc output
 ##
 makerule ./failover.E
-	depends "$(CONFIG_MAINBOARD)/failover.c ../romcc" 
-	action "../romcc -E -O --label-prefix=failover -I$(TOP)/src -I. $(CPPFLAGS) $(CONFIG_MAINBOARD)/failover.c -o $@"
+	depends "$(CONFIG_MAINBOARD)/../../../arch/i386/lib/failover.c ../romcc"
+	action "../romcc -E -O --label-prefix=failover -I$(TOP)/src -I. $(CPPFLAGS) $(CONFIG_MAINBOARD)/../../../arch/i386/lib/failover.c -o $@"
 end
 
 makerule ./failover.inc
-	depends "$(CONFIG_MAINBOARD)/failover.c ../romcc"
-	action "../romcc    -O --label-prefix=failover -I$(TOP)/src -I. $(CPPFLAGS) $(CONFIG_MAINBOARD)/failover.c -o $@"
+	depends "$(CONFIG_MAINBOARD)/../../../arch/i386/lib/failover.c ../romcc"
+	action "../romcc    -O --label-prefix=failover -I$(TOP)/src -I. $(CPPFLAGS) $(CONFIG_MAINBOARD)/../../../arch/i386/lib/failover.c -o $@"
 end
 
 makerule ./auto.E 
Index: src/mainboard/iei/nova4899r/failover.c
===================================================================
--- src/mainboard/iei/nova4899r/failover.c	(Revision 4803)
+++ src/mainboard/iei/nova4899r/failover.c	(Arbeitskopie)
@@ -1,53 +0,0 @@ 
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2007 Luis Correia <luis.f.correia@gmail.com>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
- */
-
-#define ASSEMBLY 1
-
-#include <stdint.h>
-#include <device/pci_def.h>
-#include <device/pci_ids.h>
-#include <arch/io.h>
-#include "arch/romcc_io.h"
-#include "pc80/mc146818rtc_early.c"
-
-static unsigned long main(unsigned long bist)
-{
-	/* This is the primary cpu how should I boot? */
-	if (do_normal_boot()) {
-		goto normal_image;
-	}
-	else {
-		goto fallback_image;
-	}
- normal_image:
-	asm volatile ("jmp __normal_image" 
-		: /* outputs */ 
-		: "a" (bist) /* inputs */
-		: /* clobbers */
-		);
- cpu_reset:
-	asm volatile ("jmp __cpu_reset"
-		: /* outputs */ 
-		: "a"(bist) /* inputs */
-		: /* clobbers */
-		);
- fallback_image:
-	return bist;
-}