build service results for r4795

Submitter	Myles Watson
Date	2009-10-19 15:38:41
Message ID	<2831fecf0910190838t2afbe501hc50040a5c4d805b3@mail.gmail.com>
Download	mbox \| patch
Permalink	/patch/437/
State	Not Applicable
Headers	show Return-path: <coreboot-bounces+patchwork=coreboot.org@coreboot.org> Envelope-to: patchwork@coreboot.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=RI3o4M0mRHGkg5tKUAlQfl0NUBHsydVpCq+isFhVLJxoju5D+mjNdDnxOKlkUsWzGH P/6OVjWsOAI+l5fuJwEPOhI9cKzMDreECl5UhXwlOBk07m485lheeu2naASSmm3tGk/+ hKKTFmqnVZrvKODAkRtFhLuwbaAdu8jX4Vi84= MIME-Version: 1.0 In-Reply-To: <4ADC7A65.5080300@coresystems.de> References: <E1MytZ8-00051c-K5@ra.coresystems.de> <2831fecf0910161432i4c9d4819hc342d95f761d1ab2@mail.gmail.com> <4ADC7A65.5080300@coresystems.de> Date: Mon, 19 Oct 2009 09:38:41 -0600 Message-ID: <2831fecf0910190838t2afbe501hc50040a5c4d805b3@mail.gmail.com> From: Myles Watson <mylesgw@gmail.com> To: Stefan Reinauer <stepan@coresystems.de> Cc: Patrick Georgi <patrick.georgi@coresystems.de>, coreboot@coreboot.org Subject: Re: [coreboot] build service results for r4795 Precedence: list Content-Type: multipart/mixed; boundary="===============5659186280066000465==" Sender: coreboot-bounces+patchwork=coreboot.org@coreboot.org Errors-To: coreboot-bounces+patchwork=coreboot.org@coreboot.org

Comments

Myles Watson - 2009-10-19 15:38:41

>
> > These boards build for me and have 64K left in the ROM.  How can there
> > be that big of a difference between my build system and this one?
>
> Maybe you build them without payloads? 64k sounds quite tight for two
> payloads, even though it's "just" an old filo...
>
You're right.  I hadn't realized that abuild adds a payload on the server.


> > Anybody know why they have 128K bootblocks?  It seems a little large.
>
> Can we reduce that? Patrick?
>
 ##

Passes abuild for me.

Signed-off-by: Myles Watson <mylesgw@gmail.com>

Thanks,
Myles

Peter Stuge - 2009-10-19 17:45:59

Myles Watson wrote:
> > > Anybody know why they have 128K bootblocks?  It seems a little large.
> >
> > Can we reduce that? Patrick?

It isn't 128k. That number is not used. cbfstool adjusts the size.


> Index: src/mainboard/digitallogic/msm800sev/Options.lb
> ===================================================================
> --- src/mainboard/digitallogic/msm800sev/Options.lb    (revision 4795)
> +++ src/mainboard/digitallogic/msm800sev/Options.lb    (working copy)
> @@ -97,7 +97,7 @@
>  ###
> 
>  ## CONFIG_ROM_IMAGE_SIZE is the amount of space to allow coreboot to
> occupy.
> -default CONFIG_ROM_IMAGE_SIZE = 65536
> +default CONFIG_ROM_IMAGE_SIZE = 32768
>  default CONFIG_FALLBACK_SIZE = CONFIG_ROM_IMAGE_SIZE
> 
>  ##
> Index: src/mainboard/amd/db800/Options.lb
> ===================================================================
> --- src/mainboard/amd/db800/Options.lb    (revision 4795)
> +++ src/mainboard/amd/db800/Options.lb    (working copy)
> @@ -97,7 +97,7 @@
>  ###
> 
>  ## CONFIG_ROM_IMAGE_SIZE is the amount of space to allow coreboot to
> occupy.
> -default CONFIG_ROM_IMAGE_SIZE = 65536
> +default CONFIG_ROM_IMAGE_SIZE = 32768
>  default CONFIG_FALLBACK_SIZE = CONFIG_ROM_IMAGE_SIZE
> 
>  ##
> 
> Passes abuild for me.
> 
> Signed-off-by: Myles Watson <mylesgw@gmail.com>

Acked-by: Peter Stuge <peter@stuge.se>

Myles Watson - 2009-10-19 17:49:47

> Myles Watson wrote:
> > > > Anybody know why they have 128K bootblocks?  It seems a little
> large.
> > >
> > > Can we reduce that? Patrick?
> 
> It isn't 128k. That number is not used. cbfstool adjusts the size.
The 128K was for normal + fallback.  Bootblock sizes are fixed, not adjusted
by cbfstool.
 
> > Signed-off-by: Myles Watson <mylesgw@gmail.com>
> 
> Acked-by: Peter Stuge <peter@stuge.se>
Thanks.  Sorry I was impatient.

Myles

Peter Stuge - 2009-10-19 18:50:05

Myles Watson wrote:
> > > > > Anybody know why they have 128K bootblocks?  It seems a little
> > > > > large.
> > > >
> > > > Can we reduce that? Patrick?
> > 
> > It isn't 128k. That number is not used. cbfstool adjusts the size.
> 
> The 128K was for normal + fallback.

Ok.


> Bootblock sizes are fixed, not adjusted by cbfstool.

I misunderstood Patrick on IRC then. That's very possible.


> > Acked-by: Peter Stuge <peter@stuge.se>
> 
> Thanks.  Sorry I was impatient.

No problem! As long as it got in. :)


//Peter

Patch

Index: src/mainboard/digitallogic/msm800sev/Options.lb
===================================================================
--- src/mainboard/digitallogic/msm800sev/Options.lb    (revision 4795)
+++ src/mainboard/digitallogic/msm800sev/Options.lb    (working copy)
@@ -97,7 +97,7 @@ 
 ###

 ## CONFIG_ROM_IMAGE_SIZE is the amount of space to allow coreboot to
occupy.
-default CONFIG_ROM_IMAGE_SIZE = 65536
+default CONFIG_ROM_IMAGE_SIZE = 32768
 default CONFIG_FALLBACK_SIZE = CONFIG_ROM_IMAGE_SIZE

 ##
Index: src/mainboard/amd/db800/Options.lb
===================================================================
--- src/mainboard/amd/db800/Options.lb    (revision 4795)
+++ src/mainboard/amd/db800/Options.lb    (working copy)
@@ -97,7 +97,7 @@ 
 ###

 ## CONFIG_ROM_IMAGE_SIZE is the amount of space to allow coreboot to
occupy.
-default CONFIG_ROM_IMAGE_SIZE = 65536
+default CONFIG_ROM_IMAGE_SIZE = 32768
 default CONFIG_FALLBACK_SIZE = CONFIG_ROM_IMAGE_SIZE

Patchwork build service results for r4795

Comments

Patch