Patchwork Automatically disable atapromise on non-x86

login
register
about
Submitter Carl-Daniel Hailfinger
Date 2016-02-20 21:33:26
Message ID <56C8DBA6.9070502@gmx.net>
Download mbox | patch
Permalink /patch/4389/
State Accepted
Headers show

Comments

Carl-Daniel Hailfinger - 2016-02-20 21:33:26
We do not support PCI port I/O on non-x86 (yet).
Atapromise needs PCI port I/O.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Stefan Tauner - 2016-02-20 21:37:16
On Sat, 20 Feb 2016 22:33:26 +0100
Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> wrote:

> We do not support PCI port I/O on non-x86 (yet).
> Atapromise needs PCI port I/O.
> 
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
> 
> Index: flashrom-atapromise_x86_only/Makefile
> ===================================================================
> --- flashrom-atapromise_x86_only/Makefile	(Revision 1933)
> +++ flashrom-atapromise_x86_only/Makefile	(Arbeitskopie)
> @@ -387,6 +387,11 @@
>  else
>  override CONFIG_ATAHPT = no
>  endif
> +ifeq ($(CONFIG_ATAPROMISE), yes)
> +UNSUPPORTED_FEATURES += CONFIG_ATAPROMISE=yes
> +else
> +override CONFIG_ATAPROMISE = no
> +endif
>  ifeq ($(CONFIG_SATAMV), yes)
>  UNSUPPORTED_FEATURES += CONFIG_SATAMV=yes
>  else

Acked-by: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
Carl-Daniel Hailfinger - 2016-02-20 22:05:20
On 20.02.2016 22:37, Stefan Tauner wrote:
> On Sat, 20 Feb 2016 22:33:26 +0100
> Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> wrote:
>
>> We do not support PCI port I/O on non-x86 (yet).
>> Atapromise needs PCI port I/O.
>>
>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
> Acked-by: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>

Thanks, committed in r1935.

Regards,
Carl-Daniel

Patch

Index: flashrom-atapromise_x86_only/Makefile
===================================================================
--- flashrom-atapromise_x86_only/Makefile	(Revision 1933)
+++ flashrom-atapromise_x86_only/Makefile	(Arbeitskopie)
@@ -387,6 +387,11 @@ 
 else
 override CONFIG_ATAHPT = no
 endif
+ifeq ($(CONFIG_ATAPROMISE), yes)
+UNSUPPORTED_FEATURES += CONFIG_ATAPROMISE=yes
+else
+override CONFIG_ATAPROMISE = no
+endif
 ifeq ($(CONFIG_SATAMV), yes)
 UNSUPPORTED_FEATURES += CONFIG_SATAMV=yes
 else