Patchwork Don't build atapromise on libpayload

login
register
about
Submitter Carl-Daniel Hailfinger
Date 2016-02-28 21:48:46
Message ID <56D36B3E.3040102@gmx.net>
Download mbox | patch
Permalink /patch/4410/
State Accepted
Headers show

Comments

Carl-Daniel Hailfinger - 2016-02-28 21:48:46
Reworded comment in response to Stefan's review on IRC.

Allow mstarddc_spi and pony_spi on Android.
Allow mstarddc_spi and pony_spi on architectures with unsupported raw
access.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Carl-Daniel Hailfinger - 2016-02-28 22:06:26
On 28.02.2016 22:48, Carl-Daniel Hailfinger wrote:
> Reworded comment in response to Stefan's review on IRC.
>
> Allow mstarddc_spi and pony_spi on Android.
> Allow mstarddc_spi and pony_spi on architectures with unsupported raw
> access.
>
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>

Acked on IRC.

Acked-by: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>

and committed in r1946.

Regards,
Carl-Daniel

Patch

Index: flashrom-makefile_driver_blacklist_fix_dependencies/Makefile
===================================================================
--- flashrom-makefile_driver_blacklist_fix_dependencies/Makefile	(Revision 1945)
+++ flashrom-makefile_driver_blacklist_fix_dependencies/Makefile	(Arbeitskopie)
@@ -343,6 +343,8 @@ 
 endif
 
 ifneq ($(TARGET_OS), Linux)
+# Android is handled internally as separate OS, but it supports CONFIG_LINUX_SPI and CONFIG_MSTARDDC_SPI
+ifneq ($(TARGET_OS), Android)
 ifeq ($(CONFIG_LINUX_SPI), yes)
 UNSUPPORTED_FEATURES += CONFIG_LINUX_SPI=yes
 else
@@ -354,6 +356,7 @@ 
 override CONFIG_MSTARDDC_SPI = no
 endif
 endif
+endif
 
 ifeq ($(TARGET_OS), Android)
 # Android on x86 (currently) does not provide raw PCI port I/O operations
@@ -428,11 +431,6 @@ 
 else
 override CONFIG_RAYER_SPI = no
 endif
-ifeq ($(CONFIG_PONY_SPI), yes)
-UNSUPPORTED_FEATURES += CONFIG_PONY_SPI=yes
-else
-override CONFIG_PONY_SPI = no
-endif
 ifeq ($(CONFIG_NIC3COM), yes)
 UNSUPPORTED_FEATURES += CONFIG_NIC3COM=yes
 else
@@ -463,11 +461,6 @@ 
 else
 override CONFIG_ATAPROMISE = no
 endif
-ifeq ($(CONFIG_MSTARDDC_SPI), yes)
-UNSUPPORTED_FEATURES += CONFIG_MSTARDDC_SPI=yes
-else
-override CONFIG_MSTARDDC_SPI = no
-endif
 ifeq ($(CONFIG_DRKAISER), yes)
 UNSUPPORTED_FEATURES += CONFIG_DRKAISER=yes
 else