| Submitter | Luc Verhaegen |
|---|---|
| Date | 2018-03-20 17:14:50 |
| Message ID | <20180320171450.GC29216@skynet.be> |
| Download | mbox | patch |
| Permalink | /patch/4524/ |
| State | New |
| Headers | show |
Comments
The patch worked. Thanks for your help! Cheers, Björn Am 20.03.2018 um 18:14 schrieb Luc Verhaegen: > On Tue, Mar 20, 2018 at 02:27:54PM +0100, Luc Verhaegen wrote: >> >> What this board needs is a call to intel_ich_gpio20_raise(); >> >> Will provide a patch later today. > > Attached. > >> I am a bit worried though that the lpc io BAR is empty in your lspci. I >> am not sure whether that is handled in any way, and i do not think the >> intel gpio code in flashrom will deal with an empty bar gracefully. > > Luc Verhaegen. >
I took the liberty to submit this change to gerrit; https://review.coreboot.org/#/c/flashrom/+/25396/ 2018-03-20 18:14 GMT+01:00 Luc Verhaegen <libv@skynet.be>: > On Tue, Mar 20, 2018 at 02:27:54PM +0100, Luc Verhaegen wrote: >> >> What this board needs is a call to intel_ich_gpio20_raise(); >> >> Will provide a patch later today. > > Attached. > >> I am a bit worried though that the lpc io BAR is empty in your lspci. I >> am not sure whether that is handled in any way, and i do not think the >> intel gpio code in flashrom will deal with an empty bar gracefully. > > Luc Verhaegen. > > _______________________________________________ > flashrom mailing list > flashrom@flashrom.org > https://mail.coreboot.org/mailman/listinfo/flashrom
On Wed, Mar 28, 2018 at 04:24:25PM +0200, Idwer Vollering wrote: > I took the liberty to submit this change to gerrit; > https://review.coreboot.org/#/c/flashrom/+/25396/ Please fix the author. Luc Verhaegen.
On Wed, Mar 28, 2018 at 06:49:09PM +0200, Luc Verhaegen wrote: > On Wed, Mar 28, 2018 at 04:24:25PM +0200, Idwer Vollering wrote: > > I took the liberty to submit this change to gerrit; > > https://review.coreboot.org/#/c/flashrom/+/25396/ > > Please fix the author. Thanks! Luc Verhaegen.
Patch
From 703aeb55d7ec9524bc015e09b2a1eba8adc01583 Mon Sep 17 00:00:00 2001 From: Luc Verhaegen <libv@skynet.be> Date: Tue, 20 Mar 2018 18:08:47 +0100 Subject: [PATCH 1/1] board_enable: add AOpen i965GMt-LA Signed-off-by: Luc Verhaegen <libv@skynet.be> --- board_enable.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/board_enable.c b/board_enable.c index 5e8f4dd..182a455 100644 --- a/board_enable.c +++ b/board_enable.c @@ -1692,6 +1692,7 @@ static int intel_ich_gpio19_raise(void) /* * Suited for: * - ASUS P5BV-R: LGA775 + 3200 + ICH7 + * - AOpen i965GMt-LA: Intel Socket479 + 965GM + ICH8M */ static int intel_ich_gpio20_raise(void) { @@ -2324,6 +2325,7 @@ const struct board_match board_matches[] = { {0x1022, 0x2090, 0, 0, 0x1022, 0x2080, 0, 0, NULL, "artecgroup", "dbe61", P3, "Artec Group", "DBE61", 0, OK, board_artecgroup_dbe6x}, {0x1022, 0x2090, 0, 0, 0x1022, 0x2080, 0, 0, NULL, "artecgroup", "dbe62", P3, "Artec Group", "DBE62", 0, OK, board_artecgroup_dbe6x}, {0x8086, 0x27b9, 0xa0a0, 0x0632, 0x8086, 0x27da, 0xa0a0, 0x0632, NULL, NULL, NULL, P3, "AOpen", "i945GMx-VFX", 0, OK, intel_ich_gpio38_raise}, + {0x8086, 0x2a00, 0xa0a0, 0x063e, 0x8086, 0x2815, 0xa0a0, 0x063e, NULL, NULL, NULL, P3, "AOpen", "i965GMt-LA", 0, OK, intel_ich_gpio20_raise}, {0x8086, 0x277c, 0xa0a0, 0x060b, 0x8086, 0x27da, 0xa0a0, 0x060b, NULL, NULL, NULL, P3, "AOpen", "i975Xa-YDG", 0, OK, board_aopen_i975xa_ydg}, {0x8086, 0x27A0, 0x8086, 0x7270, 0x8086, 0x27B9, 0x8086, 0x7270, "^iMac5,2$", NULL, NULL, P2, "Apple", "iMac5,2", 0, OK, p2_whitelist_laptop}, {0x8086, 0x27A0, 0x8086, 0x7270, 0x8086, 0x27B9, 0x8086, 0x7270, "^MacBook2,1$", NULL, NULL, P2, "Apple", "MacBook2,1", 0, OK, p2_whitelist_laptop}, -- 2.1.4