Patchwork reduce default verbosity of resource allocator

login
register
about
Submitter Stefan Reinauer
Date 2009-10-24 22:51:51
Message ID <4AE38507.4080000@coresystems.de>
Download mbox | patch
Permalink /patch/482/
State Accepted
Commit r4857
Headers show

Comments

Stefan Reinauer - 2009-10-24 22:51:51
See patch
Uwe Hermann - 2009-10-24 23:21:42
On Sun, Oct 25, 2009 at 12:51:51AM +0200, Stefan Reinauer wrote:
> Now that the resource allocator is working nicely we can turn down the debug
> level output and make some output SPEW only.
> 
> Signed-off-by: Stefan Reinauer <stepan@coresystems.de>

Looks good, also build-tested with some random board.

Acked-by: Uwe Hermann <uwe@hermann-uwe.de>

 
Uwe.
Myles Watson - 2009-10-25 04:03:25
> Subject: [coreboot] [PATCH] reduce default verbosity of resource allocator

Some of the "After this" and "Before that" statements could disappear now
too.

Acked-by: Myles Watson <mylesgw@gmail.com>

Thanks,
Myles

Patch

Index: src/devices/device.c
===================================================================
--- src/devices/device.c	(revision 4842)
+++ src/devices/device.c	(working copy)
@@ -890,11 +890,10 @@ 
 	printk_info("Enumerating buses...\n");
 	root = &dev_root;
 
-	show_all_devs(BIOS_DEBUG, "Before Device Enumeration.");
-	printk_debug("Compare with tree...\n");
+	show_all_devs(BIOS_SPEW, "Before Device Enumeration.");
+	printk_spew("Compare with tree...\n");
+	show_devs_tree(root, BIOS_SPEW, 0, 0);
 
-	show_devs_tree(root, BIOS_DEBUG, 0, 0);
-
 	if (root->chip_ops && root->chip_ops->enable_dev) {
 		root->chip_ops->enable_dev(root);
 	}
@@ -945,7 +944,7 @@ 
 	read_resources(&root->link[0]);
 	printk_info("Done reading resources.\n");
 
-	print_resource_tree(root, BIOS_DEBUG, "After reading.");
+	print_resource_tree(root, BIOS_SPEW, "After reading.");
 
 	/* Compute resources for all domains. */
 	for (child = root->link[0].children; child; child = child->sibling) {
@@ -1021,7 +1020,7 @@ 
 	}
 	assign_resources(&root->link[0]);
 	printk_info("Done setting resources.\n");
-	print_resource_tree(root, BIOS_DEBUG, "After assigning values.");
+	print_resource_tree(root, BIOS_SPEW, "After assigning values.");
 
 	printk_info("Done allocating resources.\n");
 }
@@ -1068,5 +1067,5 @@ 
 		}
 	}
 	printk_info("Devices initialized\n");
-	show_all_devs(BIOS_DEBUG, "After init.");
+	show_all_devs(BIOS_SPEW, "After init.");
 }