From patchwork Sun Oct 25 04:01:36 2009
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: resource allocator hole handling (simple and old)
Date: Sun, 25 Oct 2009 04:01:36 -0000
From: Myles Watson <mylesgw@gmail.com>
X-Patchwork-Id: 485
Message-Id: <81F3F3D229614447B12493A64AF500E7@chimp>
To: "'Stefan Reinauer'" <stepan@coresystems.de>,
 "'coreboot'" <coreboot@coreboot.org>

continue;

I think fixed resources of size 0 are broken.  I'd rather fix the targets.
It's hard for the allocator to avoid size 0 resources.

Thanks,
Myles


Index: src/devices/device.c
===================================================================
--- src/devices/device.c	(revision 4842)
+++ src/devices/device.c	(working copy)
@@ -576,7 +576,7 @@
 			continue;
 
 		/* Is it already outside the limits? */
-		if (res->size && (((res->base + res->size -1) < lim->base)
||
+		if (!res->size || (((res->base + res->size -1) < lim->base)
||
 				  (res->base > lim->limit)))