Patchwork Improve coreboot build output and eliminate some warnings

login
register
about
Submitter Myles Watson
Date 2009-10-27 21:09:15
Message ID <2831fecf0910271409k4710e283td0fb487b68de86d4@mail.gmail.com>
Download mbox | patch
Permalink /patch/501/
State Not Applicable
Headers show

Comments

Myles Watson - 2009-10-27 21:09:15
On Tue, Oct 27, 2009 at 1:40 PM, Uwe Hermann <uwe@hermann-uwe.de> wrote:

> Build-tested on ASUS P2B-F where 80% of the warnings are now gone.
>
Great.



Thanks,
Myles
Uwe Hermann - 2009-10-27 21:50:23
On Tue, Oct 27, 2009 at 03:09:15PM -0600, Myles Watson wrote:
> With the %p:
> Acked-by: Myles Watosn <mylesgw@gmail.com>

Thanks, r4874.


Uwe.

Patch

Index: src/arch/i386/boot/gdt.c
===================================================================
--- src/arch/i386/boot/gdt.c    (Revision 4873)
+++ src/arch/i386/boot/gdt.c    (Arbeitskopie)
@@ -47,11 +47,11 @@ 
             printk(BIOS_ERR, "Error: Could not relocate GDT.\n");
             return;
         }
-        printk_debug("Moving GDT to %#lx...", newgdt);
+        printk_debug("Moving GDT to %#lx...", (long unsigned int)newgdt);
I'd prefer just using %p since it's a pointer.

The pci_check_direct stuff needs to disappear, so it might be better to have
a warning there until it does, but I'm not picky about that either way.

With the %p:
Acked-by: Myles Watosn <mylesgw@gmail.com>