Patchwork grub as coreboot payload

login
register
about
Submitter ron minnich
Date 2009-10-29 00:27:12
Message ID <13426df10910281727p663eb63jf61754b1eedd6215@mail.gmail.com>
Download mbox | patch
Permalink /patch/509/
State Accepted
Headers show

Comments

ron minnich - 2009-10-29 00:27:12
Like this?

ron
Robert Millan - 2009-10-29 00:42:11
On Wed, Oct 28, 2009 at 05:27:12PM -0700, ron minnich wrote:
> Like this?

Looks fine to me, thanks.

Acked-by: Robert Millan <rmh.grub@aybabtu.com>

> Leave it on by default, it's cheap. 
> 
> Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
> 
> Index: src/Kconfig
> ===================================================================
> --- src/Kconfig	(revision 4887)
> +++ src/Kconfig	(working copy)
> @@ -319,7 +319,7 @@
>  
>  config MULTIBOOT
>  	bool "Generate Multiboot tables (for GRUB2)"
> -	default n
> +	default y
>  
>  config GENERATE_ACPI_TABLES
>  	depends on HAVE_ACPI_TABLES
Uwe Hermann - 2009-11-09 17:58:04
On Thu, Oct 29, 2009 at 01:42:11AM +0100, Robert Millan wrote:
> On Wed, Oct 28, 2009 at 05:27:12PM -0700, ron minnich wrote:
> > Like this?
> 
> Looks fine to me, thanks.
> 
> Acked-by: Robert Millan <rmh.grub@aybabtu.com>
> 
> > Leave it on by default, it's cheap. 
> > 
> > Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>

Thanks, acked and committed in r4929.


Uwe.

Patch

Leave it on by default, it's cheap. 

Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>

Index: src/Kconfig
===================================================================
--- src/Kconfig	(revision 4887)
+++ src/Kconfig	(working copy)
@@ -319,7 +319,7 @@ 
 
 config MULTIBOOT
 	bool "Generate Multiboot tables (for GRUB2)"
-	default n
+	default y
 
 config GENERATE_ACPI_TABLES
 	depends on HAVE_ACPI_TABLES