Patchwork Fix MP table initialization

login
register
about
Submitter Magnus Christensson
Date 2009-11-13 08:19:26
Message ID <4AFD168E.7060701@virtutech.com>
Download mbox | patch
Permalink /patch/560/
State Not Applicable
Headers show

Comments

Magnus Christensson - 2009-11-13 08:19:26
Fixes a problem introduced in one of my earlier patches.

M.
Kevin O'Connor - 2009-11-14 18:53:22
On Fri, Nov 13, 2009 at 09:19:26AM +0100, Magnus Christensson wrote:
> Fixes a problem introduced in one of my earlier patches.

I think I fixed this a different way by reworking the for() loop.

Also, I've committed patch 4 with just the addition of the
CONFIG_COREBOOT test.  Finally, I committed patch 5.  Let me know if
it looks okay.

Thanks,
-Kevin
Magnus Christensson - 2009-11-26 12:20:36
On 11/14/2009 07:53 PM, Kevin O'Connor wrote:
> On Fri, Nov 13, 2009 at 09:19:26AM +0100, Magnus Christensson wrote:
>    
>> Fixes a problem introduced in one of my earlier patches.
>>      
> I think I fixed this a different way by reworking the for() loop.
>    
Ok.
> Also, I've committed patch 4 with just the addition of the
> CONFIG_COREBOOT test.  Finally, I committed patch 5.  Let me know if
> it looks okay.
>    
Looks good.

M.

Patch

From 58063b8d781bb2d00029dfc999a18bba53860065 Mon Sep 17 00:00:00 2001
From: Magnus Christensson <mch@virtutech.com>
Date: Thu, 12 Nov 2009 16:39:35 +0100
Subject: [PATCH 11/11] Write CPU entries at the right place.

Signed-off-by: Magnus Christensson <mch@virtutech.com>
---
 src/mptable.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/mptable.c b/src/mptable.c
index 5b308ec..391fe5a 100644
--- a/src/mptable.c
+++ b/src/mptable.c
@@ -62,7 +62,7 @@  mptable_init(void)
     struct mpt_cpu *cpus = (void*)&config[1];
     int i, actual_cpu_count;
     for (i = 0, actual_cpu_count = 0; i < MaxCountCPUs; i++) {
-        struct mpt_cpu *cpu = &cpus[i];
+        struct mpt_cpu *cpu = &cpus[actual_cpu_count];
         int log_cpus = (ebx >> 16) & 0xff;
         log_cpus = 1UL << fls(log_cpus - 1); /* round up to power of 2 */
 
-- 
1.6.2.5