Submitter | Bao, Zheng |
---|---|
Date | 2009-11-30 03:01:00 |
Message ID | <DD1CC71B621B004FA76856E5129D6B1703414662@sbjgexmb1.amd.com> |
Download | mbox | patch |
Permalink | /patch/614/ |
State | Superseded |
Headers | show |
Comments
Bao, Zheng wrote: > Add support of superio sch4304. > > The datasheet of the sch4304 doesnt seems to be public. So the patch > should not be based on the information got from datasheet. Here is > the result of superiotool. > > bash# ./superiotool > superiotool r4931 > Found SMSC SCH4307 (id=0x90, rev=0x03) at 0x2e > > So we can know the Device id is 0x90. The sub-devices which I enabled > are > the ones whose LDNs don't change at all. So I believe it doesn't hurt > anyone. > > Maybe I am too sensitive, but I am not sure if the NDA is a problem > here. > > Signed-off-by: Zheng Bao <zheng.bao@amd.com> Acked-by: Peter Stuge <peter@stuge.se>
On Mon, Nov 30, 2009 at 09:45:21PM +0100, Peter Stuge wrote: > > Signed-off-by: Zheng Bao <zheng.bao@amd.com> > > Acked-by: Peter Stuge <peter@stuge.se> Thanks for the patch, r4968. I committed the original version of the patch, the LDN numbers are not in any way secret, even if there were an NDA. They can be easily guessed or tested out with hardware access. Uwe.
Patch
Index: src/superio/smsc/smscsuperio/superio.c =================================================================== --- src/superio/smsc/smscsuperio/superio.c (revision 4967) +++ src/superio/smsc/smscsuperio/superio.c (working copy) @@ -61,6 +61,7 @@ #define SCH3112 0x7c #define SCH5307 0x81 /* Rebranded LPC47B397(?) */ #define SCH5027D 0x89 +#define SCH4304 0x90 /* SCH4304, SCH4307 */ /* Register defines */ #define DEVICE_ID_REG 0x20 /* Device ID register */ @@ -137,6 +138,7 @@ {SCH3112, {0, 3, 4, 5, -1, 7, -1, -1, -1, -1, -1, -1, 10, -1, -1}}, {SCH5307, {0, 3, 4, 5, -1, 7, -1, -1, 8, -1, -1, -1, 10, -1, -1}}, {SCH5027D, {0, 3, 4, 5, -1, 7, -1, -1, -1, -1, -1, -1, 10, -1, 11}}, + {SCH4304, {0,-1, 4, -1, -1, 7, -1, -1, -1, -1, -1, -1, -1, -1, -1}}, }; /**