Submitter | Bao, Zheng |
---|---|
Date | 2009-11-30 07:30:38 |
Message ID | <DD1CC71B621B004FA76856E5129D6B17034147B6@sbjgexmb1.amd.com> |
Download | mbox | patch |
Permalink | /patch/615/ |
State | Superseded |
Headers | show |
Comments
On 30.11.2009 08:30, Bao, Zheng wrote: > Add support of superio sch4304. > > The datasheet of the sch4304 doesnt seems to be public. So the patch > should not be based on the information got from datasheet. It seems Steve Isaacs had the datasheet as well. No idea if he had to sign a NDA. http://www.mail-archive.com/linuxbios@linuxbios.org/msg14452.html Does anyone have good contacts at SMSC and can ask for a datasheet without NDA? My experience is that if you say "We will use the datasheet for the free tool XY, which makes it easier to develop hardware with your product", then you often can get datsheets very fast and even without formal NDA. > Maybe I am too sensitive, but I am not sure if the NDA is a problem > here. > > Signed-off-by: Zheng Bao <zheng.bao@amd.com> > > > Bao, Zheng wrote: >> The datasheet is not public now, isn't it? >> Does coreboot has the NDA or something else to release sch4304? Regards, Carl-Daniel
Patch
Index: src/superio/smsc/smscsuperio/superio.c =================================================================== --- src/superio/smsc/smscsuperio/superio.c (revision 4967) +++ src/superio/smsc/smscsuperio/superio.c (working copy) @@ -61,6 +61,7 @@ #define SCH3112 0x7c #define SCH5307 0x81 /* Rebranded LPC47B397(?) */ #define SCH5027D 0x89 +#define SCH4304 0x90 /* SCH4304, SCH4307 */ /* Register defines */ #define DEVICE_ID_REG 0x20 /* Device ID register */ @@ -137,6 +138,7 @@ {SCH3112, {0, 3, 4, 5, -1, 7, -1, -1, -1, -1, -1, -1, 10, -1, -1}}, {SCH5307, {0, 3, 4, 5, -1, 7, -1, -1, 8, -1, -1, -1, 10, -1, -1}}, {SCH5027D, {0, 3, 4, 5, -1, 7, -1, -1, -1, -1, -1, -1, 10, -1, 11}}, + {SCH4304, {0,-1, 4, -1, -1, 7, -1, -1, -1, -1, -1, -1, -1, -1, -1}}, }; /**