Patchwork eliminate some noise in compareboard

login
register
about
Submitter Patrick Georgi
Date 2009-12-01 17:55:30
Message ID <4B155892.9000009@georgi-clan.de>
Download mbox | patch
Permalink /patch/619/
State Accepted
Commit r4972
Headers show

Comments

Patrick Georgi - 2009-12-01 17:55:30
Hi,

attached patch eliminates some noise in the output of compareboard 
(which will show up every couple commits on this list now).
Some variables do not exist in kconfig if they're irrelevant to the 
configuration at hands.

The patch hides AMD K8/Fam10h-specific variables on non-K8/Fam10h 
boards. Currently they appear as "only in oldstyle build".
There's more to do, this is just the first step.
Once the remaining differences in configuration are done away with, 
Kconfig and newconfig should be functionally equivalent on working boards.


Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Peter Stuge - 2009-12-01 18:07:49
Patrick Georgi wrote:
> attached patch eliminates some noise in the output of compareboard
>
> Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>

Acked-by: Peter Stuge <peter@stuge.se>

Patch

Index: util/compareboard/compareboard
===================================================================
--- util/compareboard/compareboard	(revision 4971)
+++ util/compareboard/compareboard	(working copy)
@@ -23,6 +23,21 @@ 
 sort coreboot-builds/$BOARDPATH/fallback/ldoptions > $A/old
 sort build/ldoptions > $A/new
 
+if [ `grep -c "^CONFIG_NORTHBRIDGE_AMD" $A/new` -eq 0 ]; then
+	sed \
+		-e "/^CONFIG_C[BD]B / d" \
+		-e "/^CONFIG_AMDMCT / d" \
+		-e "/^CONFIG_HT3_SUPPORT / d" \
+		-e "/^CONFIG_HT_CHAIN_UNITID_BASE / d" \
+		-e "/^CONFIG_HT_CHAIN_END_UNITID_BASE / d" \
+		-e "/^CONFIG_K8_HT_FREQ_1G_SUPPORT / d" \
+		-e "/^CONFIG_K8_MEM_BANK_B_ONLY / d" \
+		-e "/^CONFIG_MEM_TRAIN_SEQ / d" \
+		-e "/^CONFIG_SB_HT_CHAIN_ON_BUS0 / d" \
+		-e "/^CONFIG_SB_HT_CHAIN_UNITID_OFFSET_ONLY / d" \
+		$A/old > $A/old.tmp && mv $A/old.tmp $A/old
+fi
+
 sed \
 	-e "/^CONFIG_CONSOLE_/ d" \
 	-e "/^CONFIG_RESET_/ d" \