Patchwork cbfstool: Fill memory allocated in create_cbfs_file() with 0xff

login
register
about
Submitter Peter Stuge
Date 2009-12-06 11:19:52
Message ID <20091206111952.18221.qmail@stuge.se>
Download mbox | patch
Permalink /patch/632/
State Accepted
Commit r4975
Headers show

Comments

Peter Stuge - 2009-12-06 11:19:52
See patch.


//Peter
cbfstool: Fill memory allocated in create_cbfs_file() with 0xff

This should improve programming speed a bit.

Signed-off-by: Peter Stuge <peter@stuge.se>
Stefan Reinauer - 2009-12-06 11:59:45
On 12/6/09 12:19 PM, Peter Stuge wrote:
> cbfstool: Fill memory allocated in create_cbfs_file() with 0xff
>
> This should improve programming speed a bit.
>
> Signed-off-by: Peter Stuge <peter@stuge.se>
>   
Unfortunately not a measurable improvement here with the Numonyx M25P32
and the Dediprog SF100, but I guess I need to figure out if it does
"smart flashing" at all.. (it did with some software release afaicr)

Anyways, good idea:
Acked-by: Stefan Reinauer <stepan@coresystems.de>

Stefan
Peter Stuge - 2009-12-06 12:15:36
Stefan Reinauer wrote:
> Acked-by: Stefan Reinauer <stepan@coresystems.de>

r4975

Patch

Index: util/cbfstool/common.c
===================================================================
--- util/cbfstool/common.c	(revision 4973)
+++ util/cbfstool/common.c	(working copy)
@@ -279,6 +279,7 @@ 
 		       headersize);
 		exit(1);
 	}
+	memset(newdata, 0xff, *datasize + headersize);
 	struct cbfs_file *nextfile = (struct cbfs_file *)newdata;
 	strncpy(nextfile->magic, "LARCHIVE", 8);
 	nextfile->len = htonl(*datasize);