Patchwork Add board enable for ECS K7S6A.

login
register
about
Submitter Luc Verhaegen
Date 2009-12-08 10:41:51
Message ID <20091208104151.GC18830@skynet.be>
Download mbox | patch
Permalink /patch/637/
State Accepted
Commit r808
Headers show

Comments

Luc Verhaegen - 2009-12-08 10:41:51
Please use the recent svn, and apply 

http://patchwork.coreboot.org/patch/635/

first.

When this works, please send:

Acked-by: [realname here] <spirals@eircom.net>

Luc Verhaegen.
From 69cad603ad1aa71b32745b3610feb1d0454b3dc3 Mon Sep 17 00:00:00 2001
From: Luc Verhaegen <libv@skynet.be>
Date: Tue, 8 Dec 2009 11:36:26 +0100
Subject: [PATCH] Boards: Add ECS K7S6A.

The nulled second set of subsystem ids is correct, and this seems
to be a unique match.

Signed-off-by: Luc Verhaegen <libv@skynet.be>
---
 board_enable.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Carl-Daniel Hailfinger - 2009-12-18 14:03:39
On 08.12.2009 11:41, Luc Verhaegen wrote:
> Please use the recent svn, and apply 
>
> http://patchwork.coreboot.org/patch/635/
>
> first.
>
> When this works, please send:
>
> Acked-by: [realname here] <spirals@eircom.net>
>   

And committed in r808 with some modifications.

Regards,
Carl-Daniel
Carl-Daniel Hailfinger - 2009-12-22 01:30:13
Hi Dave,

On 19.12.2009 20:11, spirals wrote:
> [...] no effect on my problem o/p when flashing my BIOS remains :
> flashrom v0.9.1-r792
> No coreboot table found.
> Found chipset "SiS 745", enabling flash write... FAILED!
> This chipset supports the following protocols: Non-SPI.
> Disabling flash write protection for board "Elitegroup K7S6A"... OK.
> Calibrating delay loop... OK.
> Found chip "SST SST39SF020A" (256 KB, Parallel) at physical address
> 0xfffc0000.
>
> [...] patch is in but I still get Found chipset "SiS 745", enabling
> flash write... FAILED! so write enable is NOT working. Brain is
> slightly addled, (dja.) spirals.

thanks for the report. I admit that the message is confusing. "enabling
flash write... FAILED" does not mean that write enable failed, it just
means that at least one of the expectations of the chipset write enable
function was violated. And yes, we should fix that up. The problem is
that we don't have any docs for this chipset and the code was just a guess.

However, board the flash write enable function works fine as you can see
from looking at the output: The flash chip is now found and it wasn't
found before.

> Carl-Daniel Hailfinger wrote:
>> On 08.12.2009 11:41, Luc Verhaegen wrote:  
>>> http://patchwork.coreboot.org/patch/635/ 
>>
>> And committed in r808 with some modifications.

Unless you have problems writing to the chip, I think everything is OK.

Regards,
Carl-Daniel

Patch

diff --git a/board_enable.c b/board_enable.c
index 96d764f..b070960 100644
--- a/board_enable.c
+++ b/board_enable.c
@@ -1144,6 +1144,7 @@  struct board_pciid_enable board_pciid_enables[] = {
 	{0x10DE, 0x0030, 0x1043, 0x818a,  0x8086, 0x100E, 0x1043, 0x80EE, NULL,         NULL,          "ASUS",        "P5ND2-SLI Deluxe",   nvidia_mcp_gpio10_raise},
 	{0x1106, 0x3149, 0x1565, 0x3206,  0x1106, 0x3344, 0x1565, 0x1202, NULL,         NULL,          "Biostar",     "P4M80-M4",           it8705_rom_write_enable},
 	{0x8086, 0x3590, 0x1028, 0x016c,  0x1000, 0x0030, 0x1028, 0x016c, NULL,         NULL,          "Dell",        "PowerEdge 1850",     intel_ich_gpio23_raise},
+	{0x1039, 0x5513, 0x1019, 0x0A41,  0x1039, 0x0018,      0,      0, NULL,         NULL,          "Elitegroup",  "K7S6A",              it8705f_write_enable_2e},
 	{0x1106, 0x3038, 0x1019, 0x0996,  0x1106, 0x3177, 0x1019, 0x0996, NULL,         NULL,          "Elitegroup",  "K7VTA3",             it8705f_write_enable_2e},
 	{0x1106, 0x3177, 0x1106, 0x3177,  0x1106, 0x3059, 0x1695, 0x3005, NULL,         NULL,          "EPoX",        "EP-8K5A2",           w836xx_memw_enable_2e},
 	{0x10EC, 0x8139, 0x1695, 0x9001,  0x11C1, 0x5811, 0x1695, 0x9015, NULL,         NULL,          "EPoX",        "EP-8RDA3+",          nvidia_mcp_gpio31_raise},