Patchwork Add Mitac 6513WU mainboard support

login
register
about
Submitter Michael Gold
Date 2009-07-05 23:14:32
Message ID <20090705231432.GA8536@iria.rilmarder.org>
Download mbox | patch
Permalink /patch/7/
State Accepted
Headers show

Comments

Michael Gold - 2009-07-05 23:14:32
This patch enables onboard VGA support for the Mitac 6513WU mainboard by
defining CONFIG_VIDEO_MB.

Signed-off-by: Michael Gold <mgold@ncf.ca>
---
(additional comments below)

On Sun, Jul 05, 2009 at 21:39:32 +0200, Uwe Hermann wrote:
> > +    device pci 1.0 on                   # Chipset Graphics Controller (CGC)
> > +      chip drivers/pci/onboard
> > +        device pci 1.0 on end
> > +        register "rom_address" = "0xfff80000" #512k image
> > +      end
> > +    end
> 
> I changed this part a bit, this may be nested a bit too much, but maybe
> I'm wrong, not sure. Either way, the version which is in svn now worked
> for me on the MS-6178 board, please try a plain svn checkout (r4401) and
> see if onboard VGA works (better) on your board.

The nesting seemed strange to me as well, but the example on the "VGA
support" wiki page is written like that.

After defining CONFIG_VIDEO_MB, the VGA device appears in lspci.
I haven't tried hooking up a monitor.

I noticed that you moved the subtraction of 32 KB from CONFIG_ROM_SIZE
(for the video BIOS) from the mainboard's Options.lb to the target's
Config.lb, although the rom_address for this space in still listed in
the mainboard's Config.lb.  Why was it changed?  The division between
these files doesn't appear to be well documented, and is inconsistent in
existing targets.

> > +romimage "normal"
> > +	option CONFIG_USE_FALLBACK_IMAGE = 0
> > +	option COREBOOT_EXTRA_VERSION = ".0Normal"
> > +	payload ../../../../payloads/filo.elf
> 
> Changed this to the generic "../payload.elf" we try to use
> everywhere now (but there may be more changes wrt to this
> when we move to kconfig for v2).

That's fine, but it would be good to document the recommended practice
since it's not done consistently in the existing code.

-- Michael

Patch

Index: src/mainboard/mitac/6513wu/Options.lb
===================================================================
--- src/mainboard/mitac/6513wu/Options.lb	(revision 4401)
+++ src/mainboard/mitac/6513wu/Options.lb	(working copy)
@@ -57,6 +57,7 @@ 
 uses CONFIG_USE_FALLBACK_IMAGE
 uses CONFIG_USE_INIT
 uses CONFIG_USE_OPTION_TABLE
+uses CONFIG_VIDEO_MB
 uses CONFIG_XIP_ROM_BASE
 uses CONFIG_XIP_ROM_SIZE
 uses COREBOOT_EXTRA_VERSION
@@ -106,5 +107,6 @@ 
 # Enable onboard video
 default CONFIG_CONSOLE_VGA = 1
 default CONFIG_PCI_ROM_RUN = 1
+default CONFIG_VIDEO_MB = 1
 
 end