Patchwork Improve flashchip comments

login
register
about
Submitter Carl-Daniel Hailfinger
Date 2009-07-23 12:28:50
Message ID <4A685782.50104@gmx.net>
Download mbox | patch
Permalink /patch/70/
State Accepted
Commit r665
Headers show

Comments

Carl-Daniel Hailfinger - 2009-07-23 12:28:50
Improve flashchip comments to be more readable and precise.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Luc Verhaegen - 2009-07-23 12:35:57
On Thu, Jul 23, 2009 at 02:28:50PM +0200, Carl-Daniel Hailfinger wrote:
> Improve flashchip comments to be more readable and precise.
> 
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
> 
> Index: flashrom-flashchip_comment/flashchips.c
> ===================================================================
> --- flashrom-flashchip_comment/flashchips.c	(Revision 664)
> +++ flashrom-flashchip_comment/flashchips.c	(Arbeitskopie)
> @@ -32,11 +32,20 @@
>   */
>  struct flashchip flashchips[] = {
>  
> -	/* Vendor, Chip, Vendor ID, Chip ID,
> -	 * Bus Type, 
> -	 * Total size (kB), Page size (B),
> -	 * Test status,
> -	 * Probe function, Probe function timing, Erase function, Write function, Read function
> +	/*
> +	 * .vendor		= Vendor name
> +	 * .name		= Chip name
> +	 * .bustype		= Supported flash bus types (Parallel, LPC...)
> +	 * .manufacture_id	= Manufacturer chip ID
> +	 * .model_id		= Model chip ID
> +	 * .total_size		= Total size in (binary) kbytes
> +	 * .page_size		= Page or eraseblock(?) size in bytes
> +	 * .tested		= Test status
> +	 * .probe		= Probe function
> +	 * .probe_timing	= Probe function delay
> +	 * .erase		= Chip erase function
> +	 * .write		= Chip write function
> +	 * .read		= Chip read function
>  	 */
>  
>  	{
> 
Trivial housekeeping, so

Acked-by: Luc Verhaegen <libv@skynet.be>

Luc Verhaegen.
Carl-Daniel Hailfinger - 2009-07-23 15:08:40
On 23.07.2009 14:35, Luc Verhaegen wrote:
> On Thu, Jul 23, 2009 at 02:28:50PM +0200, Carl-Daniel Hailfinger wrote:
>   
>> Improve flashchip comments to be more readable and precise.
>>
>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
>>
>>     
> Acked-by: Luc Verhaegen <libv@skynet.be>
>   

Thanks, r665.

Regards,
Carl-Daniel

Patch

Index: flashrom-flashchip_comment/flashchips.c
===================================================================
--- flashrom-flashchip_comment/flashchips.c	(Revision 664)
+++ flashrom-flashchip_comment/flashchips.c	(Arbeitskopie)
@@ -32,11 +32,20 @@ 
  */
 struct flashchip flashchips[] = {
 
-	/* Vendor, Chip, Vendor ID, Chip ID,
-	 * Bus Type, 
-	 * Total size (kB), Page size (B),
-	 * Test status,
-	 * Probe function, Probe function timing, Erase function, Write function, Read function
+	/*
+	 * .vendor		= Vendor name
+	 * .name		= Chip name
+	 * .bustype		= Supported flash bus types (Parallel, LPC...)
+	 * .manufacture_id	= Manufacturer chip ID
+	 * .model_id		= Model chip ID
+	 * .total_size		= Total size in (binary) kbytes
+	 * .page_size		= Page or eraseblock(?) size in bytes
+	 * .tested		= Test status
+	 * .probe		= Probe function
+	 * .probe_timing	= Probe function delay
+	 * .erase		= Chip erase function
+	 * .write		= Chip write function
+	 * .read		= Chip read function
 	 */
 
 	{