Patchwork M2v-mx_se asus : s3 sleeping broken since rev4625 ruik

login
register
about
Submitter Myles Watson
Date 2009-12-28 21:11:11
Message ID <2831fecf0912281311p48a10069o4b3cc5f1415301aa@mail.gmail.com>
Download mbox | patch
Permalink /patch/716/
State New
Headers show

Comments

Myles Watson - 2009-12-28 21:11:11
On Mon, Dec 28, 2009 at 1:55 PM, <congedete@voila.fr> wrote:

> Hello Rudolf,
>
> You are right. It works with your patch using buildtarget instead of
> kconfig.
> But now, I'm back to the first problem I found: when using kconfig, S3
> resume doesn't work and when using buildtarget, I can't boot opensuse
> because I get the error: initrd is too big.
>
This patch should get you most of the way to buildtarget using Kconfig.  It
minimizes the differences that are found by running

     util/kbuildall/kbuildall asus/m2v-mx_se

Thanks,
Myles
Rudolf Marek - 2009-12-28 23:33:56
>I really appreciate your help and you (and coreboot team) are a god for me at 
 >this time because I come from high level language ie csharp and it's difficult 
 >to switch to low level language,asm or linux but I try.

Btw you can boot Windows with Coreboot/SeaBIOS too ;) I think you would need to 
run the orig VGA BIOS ROM for this. But anyway you are asking good questions and 
  generally doing very well. Maybe you can help us to extend the user 
documentation to get things running -> because I think it is not so easy for 
newcomers. This needs to be fixed/improved.

Back to your problem:

I think the error message is because our memory hole is at 32MB. Maybe shifting 
this to 64MB would solve the problem.

So lets move the ramtop to 64MB and base to 63MB. I think what needs to be done 
is to replace 0x1F00000 with 0x3F00000
and 0x2000000 with 0x4000000

I think we can go to 128MB so you would need to supply the 127MB as base and 
128MB RAMTOPs (address is in hex and in bytes, just use some calc to 
128*1024*1024 and 127*1024*1024 and get result in hex).

This change is needed  either in KConfig or in the *lb files.

Thanks,
Rudolf

Patch

Index: src/mainboard/asus/m2v-mx_se/Kconfig
===================================================================
--- src/mainboard/asus/m2v-mx_se/Kconfig	(revision 4993)
+++ src/mainboard/asus/m2v-mx_se/Kconfig	(working copy)
@@ -33,6 +33,8 @@ 
 	select IOAPIC
 	select HAVE_OPTION_TABLE
 	select HAVE_ACPI_TABLES
+	select HAVE_ACPI_RESUME
+	select HAVE_MAINBOARD_RESOURCES
 	select BOARD_ROMSIZE_KB_512
 	select VGA
 
@@ -41,6 +43,16 @@ 
 	default asus/m2v-mx_se
 	depends on BOARD_ASUS_M2V_MX_SE
 
+config RAMBASE
+	hex
+	default 0x1F00000
+	depends on BOARD_ASUS_M2V_MX_SE
+
+config RAMTOP
+	hex
+	default 0x2000000
+	depends on BOARD_ASUS_M2V_MX_SE
+
 config DCACHE_RAM_BASE
 	hex
 	default 0xcc000