Patchwork Change a few probe timings to FIXME

login
register
about
Submitter Carl-Daniel Hailfinger
Date 2010-01-09 14:36:00
Message ID <4B489450.5000109@gmx.net>
Download mbox | patch
Permalink /patch/762/
State Accepted
Commit r856
Headers show

Comments

Carl-Daniel Hailfinger - 2010-01-09 14:36:00
Change a few probe timings to TIMING_FIXME. They previously had
TIMING_IGNORED, but now they use probe_jedec directly or indirectly and
that function does not ignore probe timing.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Sean Nelson - 2010-01-09 15:56:47
Acked-by: Sean Nelson <audiohacked@gmail.com>
Carl-Daniel Hailfinger - 2010-01-10 01:34:32
On 09.01.2010 16:56, Sean Nelson wrote:
> Acked-by: Sean Nelson <audiohacked@gmail.com>

Thanks, r856.

Regards,
Carl-Daniel

Patch

Index: flashrom-probe_timing_fixme/flashchips.c
===================================================================
--- flashrom-probe_timing_fixme/flashchips.c	(Revision 844)
+++ flashrom-probe_timing_fixme/flashchips.c	(Arbeitskopie)
@@ -4241,15 +4241,15 @@ 
 		.manufacture_id	= ST_ID,
 		.model_id	= ST_M50FLW040A,
 		.total_size	= 512,
 		.page_size	= 64 * 1024,
 		.feature_bits	= FEATURE_REGISTERMAP,
 		.tested		= TEST_UNTESTED,
 		.probe		= probe_jedec,
-		.probe_timing	= TIMING_IGNORED, /* routine don't use probe_timing (stm50flw0x0x.c) */
+		.probe_timing	= TIMING_FIXME,
 		.erase		= erase_stm50flw0x0x,
 		.write		= write_stm50flw0x0x,
 		.read		= read_memmapped,
 	},
 
 	{
 		.vendor		= "ST",
@@ -4258,15 +4258,15 @@ 
 		.manufacture_id	= ST_ID,
 		.model_id	= ST_M50FLW040B,
 		.total_size	= 512,
 		.page_size	= 64 * 1024,
 		.feature_bits	= FEATURE_REGISTERMAP,
 		.tested		= TEST_UNTESTED,
 		.probe		= probe_jedec,
-		.probe_timing	= TIMING_IGNORED, /* routine don't use probe_timing (stm50flw0x0x.c) */
+		.probe_timing	= TIMING_FIXME,
 		.erase		= erase_stm50flw0x0x,
 		.write		= write_stm50flw0x0x,
 		.read		= read_memmapped,
 	},
 
 	{
 		.vendor		= "ST",
@@ -4275,15 +4275,15 @@ 
 		.manufacture_id	= ST_ID,
 		.model_id	= ST_M50FLW080A,
 		.total_size	= 1024,
 		.page_size	= 64 * 1024,
 		.feature_bits	= FEATURE_REGISTERMAP,
 		.tested		= TEST_OK_PREW,
 		.probe		= probe_jedec,
-		.probe_timing	= TIMING_IGNORED, /* routine don't use probe_timing (stm50flw0x0x.c) */
+		.probe_timing	= TIMING_FIXME,
 		.erase		= erase_stm50flw0x0x,
 		.write		= write_stm50flw0x0x,
 		.read		= read_memmapped,
 	},
 
 	{
 		.vendor		= "ST",
@@ -4292,15 +4292,15 @@ 
 		.manufacture_id	= ST_ID,
 		.model_id	= ST_M50FLW080B,
 		.total_size	= 1024,
 		.page_size	= 64 * 1024,
 		.feature_bits	= FEATURE_REGISTERMAP,
 		.tested		= TEST_UNTESTED,
 		.probe		= probe_jedec,
-		.probe_timing	= TIMING_IGNORED, /* routine don't use probe_timing (stm50flw0x0x.c) */
+		.probe_timing	= TIMING_FIXME,
 		.erase		= erase_stm50flw0x0x,
 		.write		= write_stm50flw0x0x,
 		.read		= read_memmapped,
 	},
 
 	{
 		.vendor		= "ST",
@@ -4692,15 +4692,15 @@ 
 		.bustype	= CHIP_BUSTYPE_LPC,
 		.manufacture_id	= WINBOND_ID,
 		.model_id	= W_39V040C,
 		.total_size	= 512,
 		.page_size	= 64 * 1024,
 		.tested		= TEST_OK_PREW,
 		.probe		= probe_w39v040c,
-		.probe_timing	= TIMING_IGNORED, /* routine don't use probe_timing (w39v040c.c) */
+		.probe_timing	= TIMING_FIXME,
 		.erase		= erase_w39v040c,
 		.write		= write_w39v040c,
 		.read		= read_memmapped,
 	},
 
 	{
 		.vendor		= "Winbond",