Patchwork Board Enable for Intel SE440BX-2

login
register
about
Submitter Michael Karcher
Date 2010-01-26 23:58:34
Message ID <1264550314-27161-1-git-send-email-flashrom@mkarcher.dialup.fu-berlin.de>
Download mbox | patch
Permalink /patch/842/
State Superseded
Headers show

Comments

Michael Karcher - 2010-01-26 23:58:34
This board has no subsystem IDs, but thankfully the DMI patch is in
now, which is a real life safer. There are *WAY* to many 440BX/PIIX4
boards out there to match this without DMI.

Signed-off-by: Michael Karcher <flashrom@mkarcher.dialup.fu-berlin.de>
---
 board_enable.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)
Luc Verhaegen - 2010-01-27 00:39:01
On Wed, Jan 27, 2010 at 12:58:34AM +0100, Michael Karcher wrote:
> This board has no subsystem IDs, but thankfully the DMI patch is in
> now, which is a real life safer. There are *WAY* to many 440BX/PIIX4
> boards out there to match this without DMI.
> 
> Signed-off-by: Michael Karcher <flashrom@mkarcher.dialup.fu-berlin.de>
> ---
>  board_enable.c |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/board_enable.c b/board_enable.c
> index e535d4f..40db653 100644
> --- a/board_enable.c
> +++ b/board_enable.c
> @@ -651,6 +651,14 @@ static int board_epox_ep_bx3(const char *name)
>  }
>  
>  /**
> + * Suited for Intel SE440BX-2
> + */
> +static int intel_piix4_gpo27_lower(const char *name)
> +{
> +        return intel_piix4_gpo_set(27, 0);
> +}
> +
> +/**
>   * Set a GPIO line on a given intel ICH LPC controller.
>   */
>  static int intel_ich_gpio_set(int gpio, int raise)
> @@ -1218,6 +1226,7 @@ struct board_pciid_enable board_pciid_enables[] = {
>  	{0x1002, 0x438d, 0x1458, 0x5001,  0x1002, 0x5956, 0x1002, 0x5956, NULL,          NULL,         NULL,          "GIGABYTE",    "GA-MA790FX-DQ6",        0,   it87xx_probe_spi_flash},
>  	{0x1166, 0x0223, 0x103c, 0x320d,  0x102b, 0x0522, 0x103c, 0x31fa, NULL,          "hp",         "dl145_g3",    "HP",          "DL145 G3",              0,   board_hp_dl145_g3_enable},
>  	{0x1166, 0x0205, 0x1014, 0x0347,  0x1002, 0x515E, 0x1014, 0x0325, NULL,          NULL,         NULL,          "IBM",         "x3455",                 0,   board_ibm_x3455},
> +	{0x8086, 0x7190,      0,      0,  0x8086, 0x7110,      0,      0, "^SE440BX-2$", NULL,         NULL,          "Intel",       "SE440BX-2",             0,   intel_piix4_gpo27_lower},
>  	{0x1039, 0x5513, 0x8086, 0xd61f,  0x1039, 0x6330, 0x8086, 0xd61f, NULL,          NULL,         NULL,          "Intel",       "D201GLY",               0,   wbsio_check_for_spi},
>  	{0x1022, 0x7468,      0,      0,       0,      0,      0,      0, NULL,          "iwill",      "dk8_htx",     "IWILL",       "DK8-HTX",               0,   w83627hf_gpio24_raise_2e},
>  	{0x8086, 0x27A0,      0,      0,  0x8086, 0x27b8,      0,      0, NULL,          "kontron",    "986lcd-m",    "Kontron",     "986LCD-M",              0,   board_kontron_986lcd_m},
> -- 

And my piix4 code might finally get tested too :)

Luc Verhaegen.
Michael Karcher - 2010-02-26 10:11:36
[mail for having this statement in patchwork]

Am Mittwoch, den 27.01.2010, 01:39 +0100 schrieb Luc Verhaegen:
> >  /**
> > + * Suited for Intel SE440BX-2
> > + */
> > +static int intel_piix4_gpo27_lower(const char *name)
> > +{
> > +        return intel_piix4_gpo_set(27, 0);
> > +}
> And my piix4 code might finally get tested too :)

Even after fixing that code, this board enable doesn't work, as I
described in
http://www.flashrom.org/pipermail/flashrom/2010-February/002272.html 

Regards,
  Michael Karcher

Patch

diff --git a/board_enable.c b/board_enable.c
index e535d4f..40db653 100644
--- a/board_enable.c
+++ b/board_enable.c
@@ -651,6 +651,14 @@  static int board_epox_ep_bx3(const char *name)
 }
 
 /**
+ * Suited for Intel SE440BX-2
+ */
+static int intel_piix4_gpo27_lower(const char *name)
+{
+        return intel_piix4_gpo_set(27, 0);
+}
+
+/**
  * Set a GPIO line on a given intel ICH LPC controller.
  */
 static int intel_ich_gpio_set(int gpio, int raise)
@@ -1218,6 +1226,7 @@  struct board_pciid_enable board_pciid_enables[] = {
 	{0x1002, 0x438d, 0x1458, 0x5001,  0x1002, 0x5956, 0x1002, 0x5956, NULL,          NULL,         NULL,          "GIGABYTE",    "GA-MA790FX-DQ6",        0,   it87xx_probe_spi_flash},
 	{0x1166, 0x0223, 0x103c, 0x320d,  0x102b, 0x0522, 0x103c, 0x31fa, NULL,          "hp",         "dl145_g3",    "HP",          "DL145 G3",              0,   board_hp_dl145_g3_enable},
 	{0x1166, 0x0205, 0x1014, 0x0347,  0x1002, 0x515E, 0x1014, 0x0325, NULL,          NULL,         NULL,          "IBM",         "x3455",                 0,   board_ibm_x3455},
+	{0x8086, 0x7190,      0,      0,  0x8086, 0x7110,      0,      0, "^SE440BX-2$", NULL,         NULL,          "Intel",       "SE440BX-2",             0,   intel_piix4_gpo27_lower},
 	{0x1039, 0x5513, 0x8086, 0xd61f,  0x1039, 0x6330, 0x8086, 0xd61f, NULL,          NULL,         NULL,          "Intel",       "D201GLY",               0,   wbsio_check_for_spi},
 	{0x1022, 0x7468,      0,      0,       0,      0,      0,      0, NULL,          "iwill",      "dk8_htx",     "IWILL",       "DK8-HTX",               0,   w83627hf_gpio24_raise_2e},
 	{0x8086, 0x27A0,      0,      0,  0x8086, 0x27b8,      0,      0, NULL,          "kontron",    "986lcd-m",    "Kontron",     "986LCD-M",              0,   board_kontron_986lcd_m},