Patchwork Patch: Update Geode LX code to avoid FILO/Kernel problems

login
register
about
Submitter Patrick Georgi
Date 2010-01-27 17:35:44
Message ID <4B607970.1050509@georgi-clan.de>
Download mbox | patch
Permalink /patch/844/
State Accepted
Headers show

Comments

Patrick Georgi - 2010-01-27 17:35:44
Am 27.01.2010 18:26, schrieb ron minnich:
> Could we go from 768 to comething like:
> 0xc * 65536 or something? Make it really clear that it's the C segment?
> 
> Rather than commented-out code, maybe a descriptive comment so people
> who come later can know what you did? The resource code can be
> inscrutable ...
> 
> thanks
> 
> ron
> 
Like this? (wrapped and ugly, sorry about that)


 #if CONFIG_WRITE_HIGH_TABLES==1
                /* Leave some space for ACPI, PIRQ and MP tables */
ron minnich - 2010-01-27 18:03:40
That looks great

ron

Patch

Index: src/northbridge/amd/lx/northbridge.c
===================================================================
--- src/northbridge/amd/lx/northbridge.c        (revision 5057)
+++ src/northbridge/amd/lx/northbridge.c        (working copy)
@@ -411,11 +411,11 @@ 
        mc_dev = dev->link[0].children;
        if (mc_dev) {
                tomk = get_systop() / 1024;
-               /* Report the memory regions */
+               /* Report the memory regions
+                  All memory up to systop except 0xa0000-0xbffff */
                idx = 10;
                ram_resource(dev, idx++, 0, 640);
-               ram_resource(dev, idx++, 768, 1024); // c0000-fffff are
usable
-               ram_resource(dev, idx++, 1024, tomk - 1024);    //
Systop - 1 MB -> KB
+               ram_resource(dev, idx++, 768, tomk - 768);      //
Systop - 0xc0000 -> KB