| Submitter | Ward Vandewege |
|---|---|
| Date | 2010-02-03 17:50:14 |
| Message ID | <20100203175014.GA14989@countzero.vandewege.net> |
| Download | mbox | patch |
| Permalink | /patch/869/ |
| State | Accepted |
| Headers | show |
Comments
On 2/3/10 6:50 PM, Ward Vandewege wrote: > This fixes breakage introduced in r5051. > > Thanks, > Ward. > > Sorry for the inconvenience. Acked-by: Stefan Reinauer <stepan@coresystems.de>
Am 03.02.2010 18:50, schrieb Ward Vandewege: > This fixes breakage introduced in r5051. Sorry for that. I assumed newconfig would be fine: (Options.lb) #make the SB HT chain on bus 0, default is not (0) default CONFIG_SB_HT_CHAIN_ON_BUS0=0 If you want to change that in newconfig, too, consider both your patch and that change to be Acked-by: Patrick Georgi <patrick.georgi@coresystems.de>
On Wed, Feb 03, 2010 at 06:52:57PM +0100, Stefan Reinauer wrote: > On 2/3/10 6:50 PM, Ward Vandewege wrote: > > This fixes breakage introduced in r5051. > > > > Thanks, > > Ward. > > > > > Sorry for the inconvenience. > > Acked-by: Stefan Reinauer <stepan@coresystems.de> No worries - fixed in r5083 for both newconfig and Kconfig. Thanks, Ward.
On Wed, Feb 03, 2010 at 07:00:25PM +0100, Patrick Georgi wrote: > Am 03.02.2010 18:50, schrieb Ward Vandewege: > > This fixes breakage introduced in r5051. > Sorry for that. I assumed newconfig would be fine: > > (Options.lb) > #make the SB HT chain on bus 0, default is not (0) > default CONFIG_SB_HT_CHAIN_ON_BUS0=0 > > If you want to change that in newconfig, too, consider both your patch > and that change to be > Acked-by: Patrick Georgi <patrick.georgi@coresystems.de> I fixed both after boot-verifying that newconfig needed the same fix. Thanks! Thanks, Ward.
Patch
Revision 5051 broke Kconfig booting for the Tyan s2881 board. Up to 5050, there were two SB_HT_CHAIN_ON_BUS0 sections in the mainboard Kconfig file - one setting the parameter to 0, the other setting it to 2. Revision 5051 removed one of the two SB_HT_CHAIN_ON_BUS0 sections - the wrong one. This patch fixes that. Tested on real hardware. Signed-off-by: Ward Vandewege <ward@gnu.org> Index: src/mainboard/tyan/s2881/Kconfig =================================================================== --- src/mainboard/tyan/s2881/Kconfig (revision 5076) +++ src/mainboard/tyan/s2881/Kconfig (working copy) @@ -24,7 +24,7 @@ config SB_HT_CHAIN_ON_BUS0 int - default 0 + default 2 depends on BOARD_TYAN_S2881 config LB_CKS_RANGE_END