| Submitter | Harald Gutmann |
|---|---|
| Date | 2010-02-04 10:52:35 |
| Message ID | <201002041152.35530.harald.gutmann@gmx.net> |
| Download | mbox | patch |
| Permalink | /patch/879/ |
| State | Accepted |
| Commit | r5086 |
| Headers | show |
Comments
Am 04.02.2010 11:52, schrieb Harald Gutmann: > This patch fixes the build for the dsdt.asl/dsdt.c. > > Kconfig builds fine now, but I don't know right now if the resulting image works > on real hardware. > > > Sigend-off-by: Harald Gutmann <harald.gutmann@gmx.net> Acked-by: Patrick Georgi <patrick.georgi@coresystems.de> Thanks, r5086 Patrick
Thanks, but as mentioned on the IRC this should be fixed once again. The build works fine, but there is a dsdt.aml created in the / of cb, where there shouldn't be any files created. Regards, Hrald On Thursday 04 February 2010 12:09:40 Patrick Georgi wrote: > Am 04.02.2010 11:52, schrieb Harald Gutmann: > > This patch fixes the build for the dsdt.asl/dsdt.c. > > > > Kconfig builds fine now, but I don't know right now if the resulting > > image works on real hardware. > > > > > > Sigend-off-by: Harald Gutmann <harald.gutmann@gmx.net> > > Acked-by: Patrick Georgi <patrick.georgi@coresystems.de> > Thanks, r5086 > > > Patrick >
Am 04.02.2010 12:56, schrieb Harald Gutmann: > Thanks, but as mentioned on the IRC this should be fixed once again. > > The build works fine, but there is a dsdt.aml created in the / of cb, where > there shouldn't be any files created. I plan to work on unifying the ACPI generation once newconfig is gone, so I'd rather see time spent on eliminating the need for newconfig than to get ACPI generation handling to work 100% nicely (it's correct the way it is, just not nice in its choice of file placement) that will be obsolete soon (or so I hope). Patrick
Patch
Index: src/mainboard/gigabyte/m57sli/Makefile.inc =================================================================== --- src/mainboard/gigabyte/m57sli/Makefile.inc (revision 5084) +++ src/mainboard/gigabyte/m57sli/Makefile.inc (working copy) @@ -54,8 +54,8 @@ ifdef POST_EVALUATION $(obj)/dsdt.c: $(src)/mainboard/$(MAINBOARDDIR)/dsdt.asl - iasl -p $(obj)/dsdt -tc $(src)/mainboard/$(MAINBOARDDIR)/dsdt.asl - mv $(obj)/dsdt.hex $@ + iasl -p dsdt -tc $(src)/mainboard/$(MAINBOARDDIR)/dsdt.asl + mv dsdt.hex $@ $(obj)/mainboard/$(MAINBOARDDIR)/dsdt.o: $(obj)/dsdt.c $(CC) $(DISTRO_CFLAGS) $(CFLAGS) $(CPPFLAGS) $(DEBUG_CFLAGS) -I$(src) -I. -c $< -o $@