| Submitter | Patrick Georgi |
|---|---|
| Date | 2010-02-10 18:12:05 |
| Message ID | <4B72F6F5.90302@georgi-clan.de> |
| Download | mbox | patch |
| Permalink | /patch/901/ |
| State | Accepted |
| Commit | r5109 |
| Headers | show |
Comments
On 2/10/10 7:12 PM, Patrick Georgi wrote: > Better approach as solving the race condition: As we handle cbfstool as > special subdirectory, like Kconfig, create $(obj)/util/cbfstool the same > way $(obj)/util/kconfig is done. > > Why is this better? dependencies on directories are "always rebuild", as > the directory gets a new timestamp once a file in it is touched. We > don't need to rebuild cbfstool all the time. > > Am 10.02.2010 13:25, schrieb Patrick Georgi: > Still > >> Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de> >> Acked-by: Stefan Reinauer <stepan@coresystems.de>
Patch
Index: Makefile =================================================================== --- Makefile (revision 5107) +++ Makefile (working copy) @@ -254,7 +254,7 @@ prepare: mkdir -p $(obj) - mkdir -p $(obj)/util/kconfig/lxdialog + mkdir -p $(obj)/util/kconfig/lxdialog $(obj)/util/cbfstool test -n "$(alldirs)" && mkdir -p $(alldirs) || true prepare2: $(obj)/build.h
Better approach as solving the race condition: As we handle cbfstool as special subdirectory, like Kconfig, create $(obj)/util/cbfstool the same way $(obj)/util/kconfig is done. Why is this better? dependencies on directories are "always rebuild", as the directory gets a new timestamp once a file in it is touched. We don't need to rebuild cbfstool all the time. Am 10.02.2010 13:25, schrieb Patrick Georgi: Still > Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>