Patchwork drop quotes

login
register
about
Submitter Stefan Reinauer
Date 2010-02-11 10:50:08
Message ID <4B73E0E0.6090308@coresystems.de>
Download mbox | patch
Permalink /patch/907/
State Superseded
Headers show

Comments

Stefan Reinauer - 2010-02-11 10:50:08
without this patch coreboot's romstage will come up with
coreboot-4.0" <date>. starting..

The patch removes the "

Not sure what causes this, but I think romcc assumes that "" is a
protected " instead of an empty string
(Better fix might be to fix that)

Acked-by: Stefan Reinauer <stepan@coresystems.de>
Patrick Georgi - 2010-02-11 11:14:06
Am 11.02.2010 11:50, schrieb Stefan Reinauer:
> without this patch coreboot's romstage will come up with
> coreboot-4.0" <date>. starting..
> 
> The patch removes the "
> 
> Not sure what causes this, but I think romcc assumes that "" is a
> protected " instead of an empty string
> (Better fix might be to fix that)
r5116 should fix it - it certainly fixed my test case.


Patrick

Patch

Index: Makefile
===================================================================
--- Makefile	(revision 5114)
+++ Makefile	(working copy)
@@ -254,7 +254,7 @@ 
 	printf "#ifndef __BUILD_H\n" >> $(obj)/build.ht
 	printf "#define __BUILD_H\n\n" >> $(obj)/build.ht
 	printf "#define COREBOOT_VERSION \"$(KERNELVERSION)\"\n" >> $(obj)/build.ht
-	printf "#define COREBOOT_EXTRA_VERSION \"$(COREBOOT_EXTRA_VERSION)\"\n" >> $(obj)/build.ht
+	printf "#define COREBOOT_EXTRA_VERSION \"$(COREBOOT_EXTRA_VERSION) \"\n" >> $(obj)/build.ht
 	printf "#define COREBOOT_BUILD \"`LANG= date`\"\n" >> $(obj)/build.ht
 	printf "\n" >> $(obj)/build.ht
 	printf "#define COREBOOT_COMPILER \"$(shell LANG= $(CC) --version | head -n1)\"\n" >> $(obj)/build.ht
Index: src/arch/i386/lib/console.c
===================================================================
--- src/arch/i386/lib/console.c	(revision 5114)
+++ src/arch/i386/lib/console.c	(working copy)
@@ -13,7 +13,6 @@ 
 		"\r\n\r\ncoreboot-"
 		COREBOOT_VERSION
 		COREBOOT_EXTRA_VERSION
-		" "
 		COREBOOT_BUILD
 		" starting...\r\n";
 	print_info(console_test);