Patchwork : Report svnversion in Kconfig mode

login
register
about
Submitter Bao, Zheng
Date 2010-02-21 02:32:26
Message ID <DD1CC71B621B004FA76856E5129D6B17037430B9@sbjgexmb1.amd.com>
Download mbox | patch
Permalink /patch/942/
State Accepted
Headers show

Comments

Bao, Zheng - 2010-02-21 02:32:26
Finding out the svnversion we are working on is quite important,
I think. The whole string is copied from original newconfig.

Signed-off-by: Zheng Bao <zheng.bao@amd.com>


else if [ -d $(top)/.git -a -f `which git` ]; then git
--git-dir=/$(top)/.git log|grep git-svn-id|cut -f 2 -d@|cut -f 1 -d'
'|sort -g|tail -1; fi; fi)\"\n" >> $(obj)/build.ht
 	printf "#define COREBOOT_EXTRA_VERSION
\"$(COREBOOT_EXTRA_VERSION)\"\n" >> $(obj)/build.ht
 	printf "#define COREBOOT_BUILD \"`LANG= date`\"\n" >>
$(obj)/build.ht
 	printf "\n" >> $(obj)/build.ht
Patrick Georgi - 2010-02-23 10:34:38
Am 21.02.2010 03:32, schrieb Bao, Zheng:
> Finding out the svnversion we are working on is quite important,
> I think. The whole string is copied from original newconfig.
It is important.
There are a couple of GNUisms in it that I'll look into cleaning out
eventually, but for now it's good, especially as it's just a copy. Worst
case, the version string is incomplete, which is something we can live
with (just like before this commit).

> Signed-off-by: Zheng Bao <zheng.bao@amd.com>
Acked-by: Patrick Georgi <patrick.georgi@coresystems.de>

Committed as r5149


Thanks,
Patrick

Patch

Index: Makefile
===================================================================
--- Makefile	(revision 5133)
+++ Makefile	(working copy)
@@ -253,7 +253,7 @@ 
 	printf "/* build system definitions (autogenerated) */\n" >
$(obj)/build.ht
 	printf "#ifndef __BUILD_H\n" >> $(obj)/build.ht
 	printf "#define __BUILD_H\n\n" >> $(obj)/build.ht
-	printf "#define COREBOOT_VERSION \"$(KERNELVERSION)\"\n" >>
$(obj)/build.ht
+	printf "#define COREBOOT_VERSION \"$(KERNELVERSION)-r$(shell if
[ -d $(top)/.svn -a -f `which svnversion` ]; then svnversion $(top);