| Submitter | Rudolf Marek |
|---|---|
| Date | 2010-02-21 22:08:06 |
| Message ID | <4B81AEC6.70102@assembler.cz> |
| Download | mbox | patch |
| Permalink | /patch/945/ |
| State | Accepted |
| Commit | r5148 |
| Headers | show |
Comments
On 2/21/10 11:08 PM, Rudolf Marek wrote: > Hello, > > I still did not find time to fix the cbmem stuff to work on K8, making > resume > always fail. It is broken since stephan checked in the cbmem stuff. > > Also, because kconfig has RAMBASE and RAMTOP on 1M - 2M adding the > e820 reserved > region when HAVE_ACPI_RESUME is there forces the grub to fail with > "inconsistent > filesystem" - it took me 3hours to find this out. It was 31M-32M hole for > suspend/resume without memory backup. But for some reason this change > was not > correctly copied to kconfig, maybe the HAVE_MOTHERBOARD_RESOURCES was > missing > too making the mistake hard to find ;) > > Anyway, disabling the suspend/resume now. Its broken. Either cbmem > stuff needs > to be fixed, or old functionality for suspend/resume with hole must be > restored, > and for this board a hole must reside on 31MB or above. > > Signed-off-by: Rudolf Marek <r.marek@assembler.cz> Sorry for leaving this broken for so long... can't fix it, I don't have the hardware and it's not sold anymore.... Acked-by: Stefan Reinauer <stepan@coresystems.de>
Am 21.02.2010 23:08, schrieb Rudolf Marek: > Anyway, disabling the suspend/resume now. Its broken. Either cbmem stuff needs > to be fixed, or old functionality for suspend/resume with hole must be restored, Could you go to some detail as how cbmem must be fixed for your board? I'd prefer that over special solutions for single boards. > Signed-off-by: Rudolf Marek <r.marek@assembler.cz> Committed in r5148. Thanks, Patrick
Patch
Index: src/mainboard/asus/m2v-mx_se/Kconfig =================================================================== --- src/mainboard/asus/m2v-mx_se/Kconfig (revision 5134) +++ src/mainboard/asus/m2v-mx_se/Kconfig (working copy) @@ -32,7 +32,6 @@ select HAVE_HARD_RESET select HAVE_OPTION_TABLE select HAVE_ACPI_TABLES - select HAVE_ACPI_RESUME select BOARD_ROMSIZE_KB_512 select VGA select TINY_BOOTBLOCK
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello, I still did not find time to fix the cbmem stuff to work on K8, making resume always fail. It is broken since stephan checked in the cbmem stuff. Also, because kconfig has RAMBASE and RAMTOP on 1M - 2M adding the e820 reserved region when HAVE_ACPI_RESUME is there forces the grub to fail with "inconsistent filesystem" - it took me 3hours to find this out. It was 31M-32M hole for suspend/resume without memory backup. But for some reason this change was not correctly copied to kconfig, maybe the HAVE_MOTHERBOARD_RESOURCES was missing too making the mistake hard to find ;) Anyway, disabling the suspend/resume now. Its broken. Either cbmem stuff needs to be fixed, or old functionality for suspend/resume with hole must be restored, and for this board a hole must reside on 31MB or above. Signed-off-by: Rudolf Marek <r.marek@assembler.cz> Thanks Rudolf -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkuBrsYACgkQ3J9wPJqZRNXv6wCfecF+E2awc7q8RqqcHfJhVlxp IdMAoLFlcDrrVbgvpmQA95KPhOwZ5ccx =P+SA -----END PGP SIGNATURE-----