From patchwork Fri Feb 26 14:14:18 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: RE: Fam10 breakage Date: Fri, 26 Feb 2010 14:14:18 -0000 From: Myles Watson X-Patchwork-Id: 982 Message-Id: <2831fecf1002260614g38565a2amcfde229241798755@mail.gmail.com> To: Patrick Georgi Cc: coreboot@coreboot.org On Fri, Feb 26, 2010 at 5:56 AM, Patrick Georgi wrote: > Am 26.02.2010 03:48, schrieb Bao, Zheng: > > This bug leads to the fact that we can not allocate enough space of > > stack for each core. Then the data in the memory will be covered by AP > > stack which doesnt know anything. > > > > That is the fact I can find. It is a bug in the linker. But we can not > > fix each linker on coreboot developer, not to mention the fact I have > > no idea how to submit the bug. The bug will be fixed in the > > future. But when the fixed linker will come into our machine? So I > > believe we need the workaround patch to avoid this problem. > Just to make sure what the patch does: It simply removes the separate > section and reserves an area at the same place, of the same size, just > in a way that works with the linker? > I would like to double check this before it gets committed. I only tried it once, and the difference was very large. 3M of stack doesn't seem right. Thanks, Myles Acked-by: Patrick Georgi Acked-by: Patrick Georgi diff -urN 5152/coreboot_ram.map build/coreboot_ram.map --- 5152/coreboot_ram.map 2010-02-24 16:05:19.000000000 -0700 +++ build/coreboot_ram.map 2010-02-25 08:11:33.000000000 -0700 @@ -924,10 +924,10 @@ 002284a0 A _ebss 002284a0 A _end 00230000 A _stack -00240000 A _estack -00240000 A _heap -00300000 A _eheap -00300000 A _eram_seg +00530000 A _estack +00530000 A _heap +005f0000 A _eheap +005f0000 A _eram_seg 01000000 A CONFIG_RAMTOP 04000000 A CONFIG_AGP_APERTURE_SIZE fff80000 A CONFIG_XIP_ROM_BASE